Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotate-kubeconfig integration tests breaks later tests #322

Open
dguendisch opened this issue Dec 22, 2020 · 0 comments · Fixed by gardener/gardener#3328
Open

rotate-kubeconfig integration tests breaks later tests #322

dguendisch opened this issue Dec 22, 2020 · 0 comments · Fixed by gardener/gardener#3328
Labels
area/testing Testing related kind/bug Bug lifecycle/rotten Nobody worked on this for 12 months (final aging stage) priority/3 Priority (lower number equals higher priority)

Comments

@dguendisch
Copy link
Member

How to categorize this issue?
/area testing
/kind bug
/priority normal

What happened:
When promoting the integration test should rotate kubeconfig for a shoot cluster in gardener/gardener#3300 from beta to default, we missed to understand that this tests will "invalidate" the kubeconfigs used by subsequent tests.
The attempt to overcome this with gardener/gardener#3326 unfortunately doesn't work, as the kubeconfigs from TestMachinery are currently not meant to be "updated" via intermediate steps, hence all tests will only get the kubeconfigs from the create-shoot step, see e.g. this generated argo task for the e2e tests:

      - arguments:
          artifacts:
          - from: '{{tasks.create-shoot-create-testflow.outputs.artifacts.kubeconfigs}}'
            name: kubeconfigs
          ...
        dependencies:
        - shoot-default-serial-test-suite-tests-default-testflow
        name: e2e-fast-e2e-testflow

What you expected to happen:
Maybe kubeconfigs should be allowed to be overwritten by intermediate steps.

@dguendisch dguendisch added the kind/bug Bug label Dec 22, 2020
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/normal labels Mar 8, 2021
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Sep 22, 2021
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Testing related kind/bug Bug lifecycle/rotten Nobody worked on this for 12 months (final aging stage) priority/3 Priority (lower number equals higher priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants