Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary files in TM configs #410

Open
briantopping opened this issue May 25, 2022 · 0 comments
Open

Binary files in TM configs #410

briantopping opened this issue May 25, 2022 · 0 comments
Labels
lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@briantopping
Copy link
Member

briantopping commented May 25, 2022 •
edited

When TM file config is used with binary base64 data, the file is corrupted and the size of the file at stage input is larger than the original file encoded with the base64 utility.

I'm not a UTF-8 expert or read all the code paths, but I presume it's due to usage of string() typecasting and possibly due to protobufs internal to Argo. It seems likely there is some code point expansion going on as a result.
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Nov 22, 2022
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@briantopping @gardener-robot