Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimising css and better organisation throughout the app #112

Open
garimasingh128 opened this issue Jan 4, 2021 · 5 comments
Open

Optimising css and better organisation throughout the app #112

garimasingh128 opened this issue Jan 4, 2021 · 5 comments
Labels
CH20 Enhancement New feature or request Hacktoberfest Counting contributions for Hacktoberfest Hard

Comments

@garimasingh128
Copy link
Owner

We should not write CSS using style={}
We could either write CSS in js using a third-party library like emotion-js or styled-components
or we can write traditional CSS using .css or .scss file. for this approach, we can have a better folder structure like

components/
DispalyCard

  • displaycard.js
  • displaycard.css
    Footer
  • footer.js
  • footer.css
@garimasingh128 garimasingh128 added Enhancement New feature or request Hard CH20 Hacktoberfest Counting contributions for Hacktoberfest labels Jan 4, 2021
@prem315
Copy link

prem315 commented Jan 5, 2021

@garimasingh128 can you pls let me know what CSS approach we need in this project?

@garimasingh128
Copy link
Owner Author

You need to separate the CSS defined in the components into seperate JS and CSS files.
For ex:
you will create a folder in components:
DisplayCard
|- DisplayCard.js
|- DisplayCard.css

Like this for every component.

@bloodzmoon
Copy link

Can I work on this ? I'm quite new to the open source project but I will try my best 😀

@garimasingh128
Copy link
Owner Author

All the best buddy

@bloodzmoon
Copy link

bloodzmoon commented Jan 19, 2021

Please review my PR #113 😄

@bloodzmoon bloodzmoon removed their assignment Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH20 Enhancement New feature or request Hacktoberfest Counting contributions for Hacktoberfest Hard
Projects
None yet
Development

No branches or pull requests

3 participants