Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a timeline component to create a user's timeline. #5

Open
mrinal4 opened this issue Jul 9, 2020 · 23 comments
Open

Add a timeline component to create a user's timeline. #5

mrinal4 opened this issue Jul 9, 2020 · 23 comments
Assignees
Labels
CH20 Enhancement New feature or request Hacktoberfest Counting contributions for Hacktoberfest Hard

Comments

@mrinal4
Copy link
Collaborator

mrinal4 commented Jul 9, 2020

Details will be given when someone is assigned.

@mrinal4 mrinal4 added the Enhancement New feature or request label Jul 9, 2020
@AshutoshDash1999
Copy link

@garimasingh128 I want to work on this issue

@garimasingh128
Copy link
Owner

@AshutoshDash1999 Just ping me up on slack and we'll discuss how to proceed.

@AshutoshDash1999
Copy link

Will it work?
Screenshot from 2020-08-16 17-18-10

@garimasingh128
Copy link
Owner

Looks kind of empty on the side and colors are also not in sync with the theme of the app. Can you research more and try for better templates.

@AshutoshDash1999
Copy link

Edited the color with the color palate you provided, and adjusted the alignment.
Screenshot from 2020-08-16 18-57-12

Shall I look for other templates?

@garimasingh128
Copy link
Owner

Refer to this: codepen.io/tutsplus/pen/QNeJgR

I want the same with alternate cards and animation when we scroll down. You just need to change the color palette like use the exact color code of purple used in the resume or some other color used in the app. The pink looks odd so keep it neutral maybe. Then you can fetch the data with the api once the design is finalized.

@AshutoshDash1999
Copy link

how is it?
Screencast from 16-08-20 08 42 59 PM IST

@garimasingh128
Copy link
Owner

Looks perfect. Just change the color palette and move ahead with setting up the content.
You need to show the date of creating of the repo, no of stars, no of forks, description of the repo in the cards. Add if I missed something.

@AshutoshDash1999
Copy link

I have picked up the color from the resume. For showing the details from the repo I guess you will be using APIs but I'm not familiar with using API and JS. I guess you have to create another issue for that. For now can I submit a PR?

@garimasingh128
Copy link
Owner

The issue belongs to the hard category so the assigned person has to create both the front end and backend. I already shared the resources in the README. Please go through it if you have any doubts. Also, FYI the code for API fetching of the repos is already present in one of the components it's just commented. You can refer to that for help. For setting data you just have to put {repositories.name} something like this in h1, p, etc tags in jsx.

Let me know if you can get started with it.
PS: Keep the background the same for this component as the main page. You don't even need to add a background as I think I have already set it in index.html so its same for all components. The card color is good.

@AshutoshDash1999
Copy link

okay, I want to give it a shot, but I can't promise anything if I could do it succesfully!

@garimasingh128
Copy link
Owner

No issue. Ping any of the mentors on slack or me if you face any error or doubt.

@AshutoshDash1999
Copy link

Hey, I could not find the code for API fetching that you were talking about.

I guess it would be better if you can assign someone better. I need to give some more time in learning, till then I would love to took up an issue wich requires only Front-End.

@garimasingh128
Copy link
Owner

For anyone taking this issue, repos are coming as a parmeter in displaycard.js. You have to fetch them in the same way in Timeline.js component and just set the title, date of creating of the repo, no of stars, no of forks, description of the repo in the cards. Add if I missed something.

For ex: use the url : https://api.github.com/users/garimasingh128/repos to get my repos. In the same way replace garimasingh128 with the searched username.

@garimasingh128
Copy link
Owner

@AshutoshDash1999 create a PR for the frontend of the timeline.. Name it Timeline.js

@AshutoshDash1999
Copy link

@AshutoshDash1999 create a PR for the frontend of the timeline.. Name it Timeline.js

@garimasingh128 Shall I not include the html and css files?

@garimasingh128
Copy link
Owner

Didn'y you create a JS file? The project is based on react not html css. You can still create it you just need to convert it to jsx. Let me know if you can do so in a week or so or Leave the issue for other.

@AshutoshDash1999
Copy link

I'm leaving this issue for others. :)

@Akshi149
Copy link

@garimasingh128 how much time will be given to complete this issue?

@garimasingh128
Copy link
Owner

You can do it as per your convenience at max 2.5 weeks but report in slack or in comments in every 4-5 days with the progress.

@Akshi149
Copy link

I m not familiar with API and js but will try hard to learn it as soon as possible 😅

@Akshi149
Copy link

Please assign me this issue😃

@garimasingh128
Copy link
Owner

Yup. There are plenty of youtube videos that fetch repo info based on usernames. Take help from them. For the frontend of timeline there is already a link in the roadmap. You just have to convert it to jsx in react.

@garimasingh128 garimasingh128 added the Hacktoberfest Counting contributions for Hacktoberfest label Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH20 Enhancement New feature or request Hacktoberfest Counting contributions for Hacktoberfest Hard
Projects
None yet
Development

No branches or pull requests

4 participants