Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blank Space Reduced #29

Merged
merged 3 commits into from
Sep 7, 2020
Merged

Blank Space Reduced #29

merged 3 commits into from
Sep 7, 2020

Conversation

Mitali-laroia
Copy link

Description

The problem of blank space at the bottom has been solved by using
tag in DisplayCard.js. Not only it omits the blank space, but now we can see a more clear and organised view in the generated pdf.

Fixes #8

Type of change

Addition of
tag in DisplayCard.js to avoid any occurance of blank space in the bottom.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test has been done by running the project locally and detecting if the spaces and modification done doesn't disrupt the orientation of the pdf generated.

Checklist:

  • [1 ] My code follows the style guidelines of this project
  • [ 2] I have performed a self-review of my own code
  • [3 ] I have commented my code, particularly in hard-to-understand areas
  • [ 4] My changes generate no new warnings
  • [5 ] New and existing unit tests pass locally with my changes
  • [6 ] Any dependent changes have been merged and published in downstream modules

@garimasingh128
Copy link
Owner

Add a screenshot of resume component and pdf generated.

@pull-assistant
Copy link

pull-assistant bot commented Aug 17, 2020 •
edited
Loading

Score: 0.18

Best reviewed: with all changes

Optimal code review plan (3 commits squashed)

Blank Space Reduced ... Updated.

Squashed 3 commits:

Powered by Pull Assistant. Last update 632131d ... 0357b2c. Read the comment docs.

@Mitali-laroia
Copy link
Author

@garimasingh128 Screenshot of pdf generated:
Screenshot (130)
Screenshot (133)
Screenshot (131)
Screenshot (132)

@Mitali-laroia
Copy link
Author

@garimasingh128 Pls reply if this is fine or you need some more edition?

@garimasingh128
Copy link
Owner

you can also expand the purple panel to the whole length. Don't add line breaks. Just make it match the parent screen in terms of height. When we will add some more info in the panel, it will look filled and good.

@Mitali-laroia
Copy link
Author

Mitali-laroia commented Aug 18, 2020 •
edited
Loading

@garimasingh128 I have modified the code according the requirements please check now:
Screenshot (140)
Screenshot (141)
Should we close the issue?

@Mitali-laroia
Copy link
Author

@garimasingh128 Please inform me if the pull request is good for merge or you want some more modifications.

@garimasingh128
Copy link
Owner

it looks fine. I haven't reviewed it yet. ill tell once I do so. once u create a pr and get a confirmation, you are free to move to the next issue.

@Mitali-laroia Mitali-laroia changed the base branch from master to hakincodes August 22, 2020 06:20
@garimasingh128 garimasingh128 merged commit e8c320c into garimasingh128:hakincodes Sep 7, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Making the resume generated better looking with no blank space at the bottom.
3 participants
@Mitali-laroia @garimasingh128 @pikachu28