Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Django auth module from securepass lib #6

Open
andreagrandi opened this issue Aug 29, 2015 · 1 comment
Open

Separate Django auth module from securepass lib #6

andreagrandi opened this issue Aug 29, 2015 · 1 comment
Milestone

Comments

@andreagrandi
Copy link
Contributor

Django authentication module should stay in a separate package securepass-django-auth and depend on securepass. In Python libs these things are usually separated. Someone could need SecurePass lib to build an API and there is no need for Django code to be there. Don't assume that securepass will be used in Django only, there could be a Flask auth module for example.

@alessio
Copy link
Member

alessio commented Sep 3, 2015

Hi Andrea,
And thank you much for taking the time to open this issue and improve SecurePass tools!

Although it's absolutely correct to say that specific things should live in their own package as part of coherent namespaces structure, I don't think it's really worth to separate Django auth from the rest of package right now as the whole codebase is still too tiny, therefore it would not be any real benefit for the SecurePass Django users to install two separate packages instead of one.

However this is definitely a good proposal to take into account for future development so that I'm leaving it open and labelling accordingly. Thanks!

@alessio alessio added this to the Future milestone Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants