forked from kubevirt/containerized-data-importer
-
Notifications
You must be signed in to change notification settings - Fork 0
/
pvc-clone-controller.go
1399 lines (1214 loc) · 45.2 KB
/
pvc-clone-controller.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/*
Copyright 2022 The CDI Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package datavolume
import (
"context"
"crypto/rsa"
"fmt"
"reflect"
"strconv"
"github.com/go-logr/logr"
snapshotv1 "github.com/kubernetes-csi/external-snapshotter/client/v6/apis/volumesnapshot/v1"
"github.com/pkg/errors"
corev1 "k8s.io/api/core/v1"
v1 "k8s.io/api/core/v1"
storagev1 "k8s.io/api/storage/v1"
extv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
k8serrors "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/sets"
cdiv1 "kubevirt.io/containerized-data-importer-api/pkg/apis/core/v1beta1"
"kubevirt.io/containerized-data-importer/pkg/common"
cc "kubevirt.io/containerized-data-importer/pkg/controller/common"
featuregates "kubevirt.io/containerized-data-importer/pkg/feature-gates"
"kubevirt.io/containerized-data-importer/pkg/util"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/controller"
"sigs.k8s.io/controller-runtime/pkg/handler"
"sigs.k8s.io/controller-runtime/pkg/manager"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
"sigs.k8s.io/controller-runtime/pkg/source"
)
type cloneStrategy int
// Possible clone strategies, including default special value NoClone
const (
NoClone cloneStrategy = iota
HostAssistedClone
SmartClone
CsiClone
)
const pvcCloneControllerName = "datavolume-pvc-clone-controller"
// ErrInvalidTermMsg reports that the termination message from the size-detection pod doesn't exists or is not a valid quantity
var ErrInvalidTermMsg = fmt.Errorf("The termination message from the size-detection pod is not-valid")
// PvcCloneReconciler members
type PvcCloneReconciler struct {
CloneReconcilerBase
sccs controllerStarter
}
// NewPvcCloneController creates a new instance of the datavolume clone controller
func NewPvcCloneController(
ctx context.Context,
mgr manager.Manager,
log logr.Logger,
clonerImage string,
importerImage string,
pullPolicy string,
tokenPublicKey *rsa.PublicKey,
tokenPrivateKey *rsa.PrivateKey,
installerLabels map[string]string,
) (controller.Controller, error) {
client := mgr.GetClient()
sccs := &smartCloneControllerStarter{
log: log,
installerLabels: installerLabels,
startSmartCloneController: make(chan struct{}, 1),
mgr: mgr,
}
reconciler := &PvcCloneReconciler{
CloneReconcilerBase: CloneReconcilerBase{
ReconcilerBase: ReconcilerBase{
client: client,
scheme: mgr.GetScheme(),
log: log.WithName(pvcCloneControllerName),
featureGates: featuregates.NewFeatureGates(client),
recorder: mgr.GetEventRecorderFor(pvcCloneControllerName),
installerLabels: installerLabels,
},
clonerImage: clonerImage,
importerImage: importerImage,
pullPolicy: pullPolicy,
tokenValidator: cc.NewCloneTokenValidator(common.CloneTokenIssuer, tokenPublicKey),
// for long term tokens to handle cross namespace dumb clones
tokenGenerator: newLongTermCloneTokenGenerator(tokenPrivateKey),
},
sccs: sccs,
}
reconciler.Reconciler = reconciler
dataVolumeCloneController, err := controller.New(pvcCloneControllerName, mgr, controller.Options{
Reconciler: reconciler,
})
if err != nil {
return nil, err
}
if err := addDataVolumeCloneControllerWatches(mgr, dataVolumeCloneController); err != nil {
return nil, err
}
mgr.Add(sccs)
return dataVolumeCloneController, nil
}
type controllerStarter interface {
Start(ctx context.Context) error
StartController()
}
type smartCloneControllerStarter struct {
log logr.Logger
installerLabels map[string]string
startSmartCloneController chan struct{}
mgr manager.Manager
}
func (sccs *smartCloneControllerStarter) Start(ctx context.Context) error {
started := false
for {
select {
case <-sccs.startSmartCloneController:
if !started {
sccs.log.Info("Starting smart clone controller as CSI snapshot CRDs are detected")
if _, err := NewSmartCloneController(sccs.mgr, sccs.log, sccs.installerLabels); err != nil {
sccs.log.Error(err, "Unable to setup smart clone controller: %v")
} else {
started = true
}
}
case <-ctx.Done():
return nil
}
}
}
func (sccs *smartCloneControllerStarter) StartController() {
sccs.startSmartCloneController <- struct{}{}
}
func addDataVolumeCloneControllerWatches(mgr manager.Manager, datavolumeController controller.Controller) error {
if err := addDataVolumeControllerCommonWatches(mgr, datavolumeController, dataVolumePvcClone); err != nil {
return err
}
// Watch to reconcile clones created without source
if err := addCloneWithoutSourceWatch(mgr, datavolumeController, &corev1.PersistentVolumeClaim{}, "spec.source.pvc"); err != nil {
return err
}
if err := addDataSourceWatch(mgr, datavolumeController); err != nil {
return err
}
return nil
}
func addDataSourceWatch(mgr manager.Manager, c controller.Controller) error {
const dvDataSourceField = "datasource"
getKey := func(namespace, name string) string {
return namespace + "/" + name
}
if err := mgr.GetFieldIndexer().IndexField(context.TODO(), &cdiv1.DataVolume{}, dvDataSourceField, func(obj client.Object) []string {
if sourceRef := obj.(*cdiv1.DataVolume).Spec.SourceRef; sourceRef != nil && sourceRef.Kind == cdiv1.DataVolumeDataSource {
ns := obj.GetNamespace()
if sourceRef.Namespace != nil && *sourceRef.Namespace != "" {
ns = *sourceRef.Namespace
}
return []string{getKey(ns, sourceRef.Name)}
}
return nil
}); err != nil {
return err
}
mapToDataVolume := func(obj client.Object) (reqs []reconcile.Request) {
var dvs cdiv1.DataVolumeList
matchingFields := client.MatchingFields{dvDataSourceField: getKey(obj.GetNamespace(), obj.GetName())}
if err := mgr.GetClient().List(context.TODO(), &dvs, matchingFields); err != nil {
c.GetLogger().Error(err, "Unable to list DataVolumes", "matchingFields", matchingFields)
return
}
for _, dv := range dvs.Items {
reqs = append(reqs, reconcile.Request{NamespacedName: types.NamespacedName{Namespace: dv.Namespace, Name: dv.Name}})
}
return
}
if err := c.Watch(&source.Kind{Type: &cdiv1.DataSource{}},
handler.EnqueueRequestsFromMapFunc(mapToDataVolume),
); err != nil {
return err
}
return nil
}
// Reconcile loop for the clone data volumes
func (r *PvcCloneReconciler) Reconcile(ctx context.Context, req reconcile.Request) (reconcile.Result, error) {
return r.reconcile(ctx, req, r)
}
func (r *PvcCloneReconciler) prepare(syncState *dvSyncState) error {
dv := syncState.dvMutated
if err := r.populateSourceIfSourceRef(dv); err != nil {
return err
}
if dv.Status.Phase == cdiv1.Succeeded {
if err := r.cleanup(syncState); err != nil {
return err
}
}
return nil
}
func (r *PvcCloneReconciler) updateAnnotations(dataVolume *cdiv1.DataVolume, pvc *corev1.PersistentVolumeClaim) error {
if dataVolume.Spec.Source.PVC == nil {
return errors.Errorf("no source set for clone datavolume")
}
sourceNamespace := dataVolume.Spec.Source.PVC.Namespace
if sourceNamespace == "" {
sourceNamespace = dataVolume.Namespace
}
token, ok := dataVolume.Annotations[cc.AnnCloneToken]
if !ok {
return errors.Errorf("no clone token")
}
pvc.Annotations[cc.AnnCloneToken] = token
pvc.Annotations[cc.AnnCloneRequest] = sourceNamespace + "/" + dataVolume.Spec.Source.PVC.Name
return nil
}
func (r *PvcCloneReconciler) sync(log logr.Logger, req reconcile.Request) (dvSyncResult, error) {
syncState, err := r.syncClone(log, req)
if err == nil {
err = r.syncUpdate(log, &syncState)
}
return syncState.dvSyncResult, err
}
func (r *PvcCloneReconciler) syncClone(log logr.Logger, req reconcile.Request) (dvSyncState, error) {
syncRes, syncErr := r.syncCommon(log, req, r.cleanup, r.prepare)
if syncErr != nil || syncRes.result != nil {
return syncRes, syncErr
}
pvc := syncRes.pvc
pvcSpec := syncRes.pvcSpec
datavolume := syncRes.dvMutated
transferName := getTransferName(datavolume)
// Get the most appropiate clone strategy
selectedCloneStrategy, err := r.selectCloneStrategy(datavolume, pvcSpec)
if err != nil {
return syncRes, err
}
if selectedCloneStrategy != NoClone {
cc.AddAnnotation(datavolume, annCloneType, cloneStrategyToCloneType(selectedCloneStrategy))
}
pvcPopulated := pvcIsPopulated(pvc, datavolume)
staticProvisionPending := checkStaticProvisionPending(pvc, datavolume)
prePopulated := dvIsPrePopulated(datavolume)
if pvcPopulated || prePopulated || staticProvisionPending {
return syncRes, nil
}
// Check if source PVC exists and do proper validation before attempting to clone
if done, err := r.validateCloneAndSourcePVC(&syncRes); err != nil {
return syncRes, err
} else if !done {
return syncRes, nil
}
if selectedCloneStrategy == SmartClone {
r.sccs.StartController()
}
// If the target's size is not specified, we can extract that value from the source PVC
targetRequest, hasTargetRequest := pvcSpec.Resources.Requests[corev1.ResourceStorage]
if !hasTargetRequest || targetRequest.IsZero() {
done, err := r.detectCloneSize(&syncRes, selectedCloneStrategy)
if err != nil {
return syncRes, err
} else if !done {
// Check if the source PVC is ready to be cloned
if readyToClone, err := r.isSourceReadyToClone(datavolume, selectedCloneStrategy); err != nil {
return syncRes, err
} else if !readyToClone {
if syncRes.result == nil {
syncRes.result = &reconcile.Result{}
}
syncRes.result.Requeue = true
return syncRes,
r.syncCloneStatusPhase(&syncRes, cdiv1.CloneScheduled, nil)
}
return syncRes, nil
}
}
if pvc == nil {
if selectedCloneStrategy == SmartClone {
snapshotClassName, err := r.getSnapshotClassForSmartClone(datavolume, pvcSpec)
if err != nil {
return syncRes, err
}
res, err := r.reconcileSmartClonePvc(log, &syncRes, transferName, snapshotClassName)
syncRes.result = &res
return syncRes, err
}
if selectedCloneStrategy == CsiClone {
csiDriverAvailable, err := r.storageClassCSIDriverExists(pvcSpec.StorageClassName)
if err != nil && !k8serrors.IsNotFound(err) {
return syncRes, err
}
if !csiDriverAvailable {
// err csi clone not possible
storageClass, err := cc.GetStorageClassByName(r.client, pvcSpec.StorageClassName)
if err != nil {
return syncRes, err
}
noCsiDriverMsg := "CSI Clone configured, failed to look for CSIDriver - target storage class could not be found"
if storageClass != nil {
noCsiDriverMsg = fmt.Sprintf("CSI Clone configured, but no CSIDriver available for %s", storageClass.Name)
}
return syncRes,
r.syncDataVolumeStatusPhaseWithEvent(&syncRes, cdiv1.CloneScheduled, pvc,
Event{
eventType: corev1.EventTypeWarning,
reason: ErrUnableToClone,
message: noCsiDriverMsg,
})
}
res, err := r.reconcileCsiClonePvc(log, &syncRes, transferName)
syncRes.result = &res
return syncRes, err
}
newPvc, err := r.createPvcForDatavolume(datavolume, pvcSpec, r.updateAnnotations)
if err != nil {
if cc.ErrQuotaExceeded(err) {
r.syncDataVolumeStatusPhaseWithEvent(&syncRes, cdiv1.Pending, nil,
Event{
eventType: corev1.EventTypeWarning,
reason: cc.ErrExceededQuota,
message: err.Error(),
})
}
return syncRes, err
}
pvc = newPvc
}
shouldBeMarkedWaitForFirstConsumer, err := r.shouldBeMarkedWaitForFirstConsumer(pvc)
if err != nil {
return syncRes, err
}
switch selectedCloneStrategy {
case HostAssistedClone:
if err := r.ensureExtendedToken(pvc); err != nil {
return syncRes, err
}
case CsiClone:
switch pvc.Status.Phase {
case corev1.ClaimBound:
if err := r.setCloneOfOnPvc(pvc); err != nil {
return syncRes, err
}
case corev1.ClaimPending:
r.log.V(3).Info("ClaimPending CSIClone")
if !shouldBeMarkedWaitForFirstConsumer {
return syncRes, r.syncCloneStatusPhase(&syncRes, cdiv1.CSICloneInProgress, pvc)
}
case corev1.ClaimLost:
return syncRes,
r.syncDataVolumeStatusPhaseWithEvent(&syncRes, cdiv1.Failed, pvc,
Event{
eventType: corev1.EventTypeWarning,
reason: ErrClaimLost,
message: fmt.Sprintf(MessageErrClaimLost, pvc.Name),
})
}
fallthrough
case SmartClone:
if !shouldBeMarkedWaitForFirstConsumer {
res, err := r.finishClone(log, &syncRes, transferName)
syncRes.result = &res
return syncRes, err
}
}
return syncRes, syncErr
}
func (r *PvcCloneReconciler) selectCloneStrategy(datavolume *cdiv1.DataVolume, pvcSpec *corev1.PersistentVolumeClaimSpec) (cloneStrategy, error) {
preferredCloneStrategy, err := r.getCloneStrategy(datavolume)
if err != nil {
if k8serrors.IsNotFound(err) {
return NoClone, nil
}
return NoClone, err
}
bindingMode, err := r.getStorageClassBindingMode(pvcSpec.StorageClassName)
if err != nil {
return NoClone, err
}
if preferredCloneStrategy != nil && *preferredCloneStrategy == cdiv1.CloneStrategyCsiClone {
csiClonePossible, err := r.advancedClonePossible(datavolume, pvcSpec)
if err != nil {
return NoClone, err
}
if csiClonePossible &&
(!isCrossNamespaceClone(datavolume) || *bindingMode == storagev1.VolumeBindingImmediate) {
return CsiClone, nil
}
} else if preferredCloneStrategy != nil && *preferredCloneStrategy == cdiv1.CloneStrategySnapshot {
snapshotClassName, err := r.getSnapshotClassForSmartClone(datavolume, pvcSpec)
if err != nil {
return NoClone, err
}
snapshotClassAvailable := snapshotClassName != ""
snapshotPossible, err := r.advancedClonePossible(datavolume, pvcSpec)
if err != nil {
return NoClone, err
}
if snapshotClassAvailable && snapshotPossible &&
(!isCrossNamespaceClone(datavolume) || *bindingMode == storagev1.VolumeBindingImmediate) {
return SmartClone, nil
}
}
return HostAssistedClone, nil
}
func (r *PvcCloneReconciler) reconcileCsiClonePvc(log logr.Logger,
syncRes *dvSyncState,
transferName string) (reconcile.Result, error) {
log = log.WithName("reconcileCsiClonePvc")
datavolume := syncRes.dvMutated
pvcSpec := syncRes.pvcSpec
pvcName := datavolume.Name
if isCrossNamespaceClone(datavolume) {
pvcName = transferName
result, err := r.doCrossNamespaceClone(log, syncRes, pvcName, datavolume.Spec.Source.PVC.Namespace, false, CsiClone)
if result != nil {
return *result, err
}
}
if datavolume.Status.Phase == cdiv1.NamespaceTransferInProgress {
return reconcile.Result{}, nil
}
sourcePvcNs := datavolume.Spec.Source.PVC.Namespace
if sourcePvcNs == "" {
sourcePvcNs = datavolume.Namespace
}
log.V(3).Info("CSI-Clone is available")
// Get source pvc
sourcePvc := &corev1.PersistentVolumeClaim{}
if err := r.client.Get(context.TODO(), types.NamespacedName{Namespace: sourcePvcNs, Name: datavolume.Spec.Source.PVC.Name}, sourcePvc); err != nil {
if k8serrors.IsNotFound(err) {
log.V(3).Info("Source PVC no longer exists")
return reconcile.Result{}, err
}
return reconcile.Result{}, err
}
// Check if the source PVC is ready to be cloned
if readyToClone, err := r.isSourceReadyToClone(datavolume, CsiClone); err != nil {
return reconcile.Result{}, err
} else if !readyToClone {
return reconcile.Result{Requeue: true},
r.syncCloneStatusPhase(syncRes, cdiv1.CloneScheduled, nil)
}
log.Info("Creating PVC for datavolume")
cloneTargetPvc, err := r.newVolumeClonePVC(datavolume, sourcePvc, pvcSpec, pvcName)
if err != nil {
return reconcile.Result{}, err
}
pvc := &corev1.PersistentVolumeClaim{}
if err := r.client.Get(context.TODO(), types.NamespacedName{Namespace: cloneTargetPvc.Namespace, Name: cloneTargetPvc.Name}, pvc); err != nil {
if !k8serrors.IsNotFound(err) {
return reconcile.Result{}, err
}
if err := r.client.Create(context.TODO(), cloneTargetPvc); err != nil && !k8serrors.IsAlreadyExists(err) {
if cc.ErrQuotaExceeded(err) {
r.syncDataVolumeStatusPhaseWithEvent(syncRes, cdiv1.Pending, nil,
Event{
eventType: corev1.EventTypeWarning,
reason: cc.ErrExceededQuota,
message: err.Error(),
})
}
return reconcile.Result{}, err
}
} else {
// PVC already exists, check for name clash
pvcControllerRef := metav1.GetControllerOf(cloneTargetPvc)
pvcClashControllerRef := metav1.GetControllerOf(pvc)
if pvc.Name == cloneTargetPvc.Name &&
pvc.Namespace == cloneTargetPvc.Namespace &&
!reflect.DeepEqual(pvcControllerRef, pvcClashControllerRef) {
return reconcile.Result{}, errors.Errorf("Target Pvc Name in use")
}
if pvc.Status.Phase == corev1.ClaimBound {
if err := r.setCloneOfOnPvc(pvc); err != nil {
return reconcile.Result{}, err
}
}
}
return reconcile.Result{}, r.syncCloneStatusPhase(syncRes, cdiv1.CSICloneInProgress, nil)
}
func cloneStrategyToCloneType(selectedCloneStrategy cloneStrategy) string {
switch selectedCloneStrategy {
case SmartClone:
return "snapshot"
case CsiClone:
return "csivolumeclone"
case HostAssistedClone:
return "network"
}
return ""
}
func (r *PvcCloneReconciler) reconcileSmartClonePvc(log logr.Logger,
syncState *dvSyncState,
transferName string,
snapshotClassName string) (reconcile.Result, error) {
datavolume := syncState.dvMutated
pvcName := datavolume.Name
if isCrossNamespaceClone(datavolume) {
pvcName = transferName
result, err := r.doCrossNamespaceClone(log, syncState, pvcName, datavolume.Spec.Source.PVC.Namespace, true, SmartClone)
if result != nil {
return *result, err
}
}
if datavolume.Status.Phase == cdiv1.NamespaceTransferInProgress {
return reconcile.Result{}, nil
}
r.log.V(3).Info("Smart-Clone via Snapshot is available with Volume Snapshot Class",
"snapshotClassName", snapshotClassName)
newSnapshot := newSnapshot(datavolume, pvcName, snapshotClassName)
util.SetRecommendedLabels(newSnapshot, r.installerLabels, "cdi-controller")
if err := setAnnOwnedByDataVolume(newSnapshot, datavolume); err != nil {
return reconcile.Result{}, err
}
nn := client.ObjectKeyFromObject(newSnapshot)
if err := r.client.Get(context.TODO(), nn, newSnapshot.DeepCopy()); err != nil {
if !k8serrors.IsNotFound(err) {
return reconcile.Result{}, err
}
// Check if the source PVC is ready to be cloned
if readyToClone, err := r.isSourceReadyToClone(datavolume, SmartClone); err != nil {
return reconcile.Result{}, err
} else if !readyToClone {
return reconcile.Result{Requeue: true},
r.syncCloneStatusPhase(syncState, cdiv1.CloneScheduled, nil)
}
targetPvc := &corev1.PersistentVolumeClaim{}
if err := r.client.Get(context.TODO(), nn, targetPvc); err != nil {
if !k8serrors.IsNotFound(err) {
return reconcile.Result{}, err
}
if err := r.client.Create(context.TODO(), newSnapshot); err != nil {
if !k8serrors.IsAlreadyExists(err) {
return reconcile.Result{}, err
}
} else {
r.log.V(1).Info("snapshot created successfully", "snapshot.Namespace", newSnapshot.Namespace, "snapshot.Name", newSnapshot.Name)
}
}
}
return reconcile.Result{}, r.syncCloneStatusPhase(syncState, cdiv1.SnapshotForSmartCloneInProgress, nil)
}
func newSnapshot(dataVolume *cdiv1.DataVolume, snapshotName, snapshotClassName string) *snapshotv1.VolumeSnapshot {
annotations := make(map[string]string)
annotations[AnnSmartCloneRequest] = "true"
className := snapshotClassName
labels := map[string]string{
common.CDILabelKey: common.CDILabelValue,
common.CDIComponentLabel: common.SmartClonerCDILabel,
}
snapshotNamespace := dataVolume.Namespace
if dataVolume.Spec.Source.PVC.Namespace != "" {
snapshotNamespace = dataVolume.Spec.Source.PVC.Namespace
}
snapshot := &snapshotv1.VolumeSnapshot{
ObjectMeta: metav1.ObjectMeta{
Name: snapshotName,
Namespace: snapshotNamespace,
Labels: labels,
Annotations: annotations,
},
Spec: snapshotv1.VolumeSnapshotSpec{
Source: snapshotv1.VolumeSnapshotSource{
PersistentVolumeClaimName: &dataVolume.Spec.Source.PVC.Name,
},
VolumeSnapshotClassName: &className,
},
}
if dataVolume.Namespace == snapshotNamespace {
snapshot.OwnerReferences = []metav1.OwnerReference{
*metav1.NewControllerRef(dataVolume, schema.GroupVersionKind{
Group: cdiv1.SchemeGroupVersion.Group,
Version: cdiv1.SchemeGroupVersion.Version,
Kind: "DataVolume",
}),
}
}
return snapshot
}
// Verify that the source PVC has been completely populated.
func (r *PvcCloneReconciler) isSourcePVCPopulated(dv *cdiv1.DataVolume) (bool, error) {
sourcePvc := &corev1.PersistentVolumeClaim{}
if err := r.client.Get(context.TODO(), types.NamespacedName{Name: dv.Spec.Source.PVC.Name, Namespace: dv.Spec.Source.PVC.Namespace}, sourcePvc); err != nil {
return false, err
}
return cc.IsPopulated(sourcePvc, r.client)
}
func (r *PvcCloneReconciler) sourceInUse(dv *cdiv1.DataVolume, eventReason string) (bool, error) {
pods, err := cc.GetPodsUsingPVCs(r.client, dv.Spec.Source.PVC.Namespace, sets.NewString(dv.Spec.Source.PVC.Name), false)
if err != nil {
return false, err
}
for _, pod := range pods {
r.log.V(1).Info("Cannot snapshot",
"namespace", dv.Namespace, "name", dv.Name, "pod namespace", pod.Namespace, "pod name", pod.Name)
r.recorder.Eventf(dv, corev1.EventTypeWarning, eventReason,
"pod %s/%s using PersistentVolumeClaim %s", pod.Namespace, pod.Name, dv.Spec.Source.PVC.Name)
}
return len(pods) > 0, nil
}
func (r *PvcCloneReconciler) cleanup(syncState *dvSyncState) error {
dv := syncState.dvMutated
r.log.V(3).Info("Cleanup initiated in dv PVC clone controller")
if isCrossNamespaceClone(dv) {
if err := r.cleanupTransfer(dv); err != nil {
return err
}
}
return nil
}
func (r *PvcCloneReconciler) getSnapshotClassForSmartClone(dataVolume *cdiv1.DataVolume, targetStorageSpec *corev1.PersistentVolumeClaimSpec) (string, error) {
log := r.log.WithName("getSnapshotClassForSmartClone").V(3)
// Check if relevant CRDs are available
if !isCsiCrdsDeployed(r.client, r.log) {
log.Info("Missing CSI snapshotter CRDs, falling back to host assisted clone")
return "", nil
}
targetPvcStorageClassName := targetStorageSpec.StorageClassName
targetStorageClass, err := cc.GetStorageClassByName(r.client, targetPvcStorageClassName)
if err != nil {
return "", err
}
if targetStorageClass == nil {
log.Info("Target PVC's Storage Class not found")
return "", nil
}
targetPvcStorageClassName = &targetStorageClass.Name
// Fetch the source storage class
srcStorageClass := &storagev1.StorageClass{}
if err := r.client.Get(context.TODO(), types.NamespacedName{Name: *targetPvcStorageClassName}, srcStorageClass); err != nil {
log.Info("Unable to retrieve storage class, falling back to host assisted clone", "storage class", *targetPvcStorageClassName)
return "", err
}
// List the snapshot classes
scs := &snapshotv1.VolumeSnapshotClassList{}
if err := r.client.List(context.TODO(), scs); err != nil {
log.Info("Cannot list snapshot classes, falling back to host assisted clone")
return "", err
}
for _, snapshotClass := range scs.Items {
// Validate association between snapshot class and storage class
if snapshotClass.Driver == srcStorageClass.Provisioner {
log.Info("smart-clone is applicable for datavolume", "datavolume",
dataVolume.Name, "snapshot class", snapshotClass.Name)
return snapshotClass.Name, nil
}
}
log.Info("Could not match snapshotter with storage class, falling back to host assisted clone")
return "", nil
}
// isCsiCrdsDeployed checks whether the CSI snapshotter CRD are deployed
func isCsiCrdsDeployed(c client.Client, log logr.Logger) bool {
version := "v1"
vsClass := "volumesnapshotclasses." + snapshotv1.GroupName
vsContent := "volumesnapshotcontents." + snapshotv1.GroupName
vs := "volumesnapshots." + snapshotv1.GroupName
return isCrdDeployed(c, vsClass, version, log) &&
isCrdDeployed(c, vsContent, version, log) &&
isCrdDeployed(c, vs, version, log)
}
// isCrdDeployed checks whether a CRD is deployed
func isCrdDeployed(c client.Client, name, version string, log logr.Logger) bool {
crd := &extv1.CustomResourceDefinition{}
err := c.Get(context.TODO(), types.NamespacedName{Name: name}, crd)
if err != nil {
if !k8serrors.IsNotFound(err) {
log.Info("Error looking up CRD", "crd name", name, "version", version, "error", err)
}
return false
}
for _, v := range crd.Spec.Versions {
if v.Name == version && v.Served {
return true
}
}
return false
}
// Returns true if methods different from HostAssisted are possible,
// both snapshot and csi volume clone share the same basic requirements
func (r *PvcCloneReconciler) advancedClonePossible(dataVolume *cdiv1.DataVolume, targetStorageSpec *corev1.PersistentVolumeClaimSpec) (bool, error) {
log := r.log.WithName("ClonePossible").V(3)
sourcePvc, err := r.findSourcePvc(dataVolume)
if err != nil {
if k8serrors.IsNotFound(err) {
return false, errors.New("source PVC not found")
}
return false, err
}
targetStorageClass, err := cc.GetStorageClassByName(r.client, targetStorageSpec.StorageClassName)
if err != nil {
return false, err
}
if targetStorageClass == nil {
log.Info("Target PVC's Storage Class not found")
return false, nil
}
if ok := r.validateSameStorageClass(sourcePvc, targetStorageClass); !ok {
return false, nil
}
if ok, err := r.validateSameVolumeMode(dataVolume, sourcePvc, targetStorageClass); !ok || err != nil {
return false, err
}
return r.validateAdvancedCloneSizeCompatible(sourcePvc, targetStorageSpec)
}
func (r *PvcCloneReconciler) validateSameStorageClass(
sourcePvc *corev1.PersistentVolumeClaim,
targetStorageClass *storagev1.StorageClass) bool {
targetPvcStorageClassName := &targetStorageClass.Name
sourcePvcStorageClassName := sourcePvc.Spec.StorageClassName
// Compare source and target storage classess
if *sourcePvcStorageClassName != *targetPvcStorageClassName {
r.log.V(3).Info("Source PVC and target PVC belong to different storage classes",
"source storage class", *sourcePvcStorageClassName,
"target storage class", *targetPvcStorageClassName)
return false
}
return true
}
func (r *PvcCloneReconciler) validateSameVolumeMode(
dataVolume *cdiv1.DataVolume,
sourcePvc *corev1.PersistentVolumeClaim,
targetStorageClass *storagev1.StorageClass) (bool, error) {
sourceVolumeMode := util.ResolveVolumeMode(sourcePvc.Spec.VolumeMode)
targetSpecVolumeMode, err := getStorageVolumeMode(r.client, dataVolume, targetStorageClass)
if err != nil {
return false, err
}
targetVolumeMode := util.ResolveVolumeMode(targetSpecVolumeMode)
if sourceVolumeMode != targetVolumeMode {
r.log.V(3).Info("Source PVC and target PVC have different volume modes, falling back to host assisted clone",
"source volume mode", sourceVolumeMode, "target volume mode", targetVolumeMode)
return false, nil
}
return true, nil
}
func getStorageVolumeMode(c client.Client, dataVolume *cdiv1.DataVolume, storageClass *storagev1.StorageClass) (*corev1.PersistentVolumeMode, error) {
if dataVolume.Spec.PVC != nil {
return dataVolume.Spec.PVC.VolumeMode, nil
} else if dataVolume.Spec.Storage != nil {
if dataVolume.Spec.Storage.VolumeMode != nil {
return dataVolume.Spec.Storage.VolumeMode, nil
}
volumeMode, err := getDefaultVolumeMode(c, storageClass, dataVolume.Spec.Storage.AccessModes)
if err != nil {
return nil, err
}
return volumeMode, nil
}
return nil, errors.Errorf("no target storage defined")
}
func (r *PvcCloneReconciler) validateAdvancedCloneSizeCompatible(
sourcePvc *corev1.PersistentVolumeClaim,
targetStorageSpec *corev1.PersistentVolumeClaimSpec) (bool, error) {
srcStorageClass := &storagev1.StorageClass{}
if sourcePvc.Spec.StorageClassName == nil {
return false, fmt.Errorf("Source PVC Storage Class name wasn't populated yet by PVC controller")
}
if err := r.client.Get(context.TODO(), types.NamespacedName{Name: *sourcePvc.Spec.StorageClassName}, srcStorageClass); cc.IgnoreNotFound(err) != nil {
return false, err
}
srcRequest, hasSrcRequest := sourcePvc.Spec.Resources.Requests[corev1.ResourceStorage]
srcCapacity, hasSrcCapacity := sourcePvc.Status.Capacity[corev1.ResourceStorage]
targetRequest, hasTargetRequest := targetStorageSpec.Resources.Requests[corev1.ResourceStorage]
allowExpansion := srcStorageClass.AllowVolumeExpansion != nil && *srcStorageClass.AllowVolumeExpansion
if !hasSrcRequest || !hasSrcCapacity || !hasTargetRequest {
// return error so we retry the reconcile
return false, errors.New("source/target size info missing")
}
if srcCapacity.Cmp(targetRequest) < 0 && !allowExpansion {
return false, nil
}
if srcRequest.Cmp(targetRequest) > 0 && !targetRequest.IsZero() {
return false, nil
}
return true, nil
}
func (r *PvcCloneReconciler) getCloneStrategy(dataVolume *cdiv1.DataVolume) (*cdiv1.CDICloneStrategy, error) {
defaultCloneStrategy := cdiv1.CloneStrategySnapshot
sourcePvc, err := r.findSourcePvc(dataVolume)
if err != nil {
return nil, err
}
storageClass, err := cc.GetStorageClassByName(r.client, sourcePvc.Spec.StorageClassName)
if err != nil {
return nil, err
}
strategyOverride, err := r.getGlobalCloneStrategyOverride()
if err != nil {
return nil, err
}
if strategyOverride != nil {
return strategyOverride, nil
}
// do check storageProfile and apply the preferences
strategy, err := r.getPreferredCloneStrategyForStorageClass(storageClass)
if err != nil {
return nil, err
}
if strategy != nil {
return strategy, err
}
return &defaultCloneStrategy, nil
}
func (r *PvcCloneReconciler) findSourcePvc(dataVolume *cdiv1.DataVolume) (*corev1.PersistentVolumeClaim, error) {
sourcePvcSpec := dataVolume.Spec.Source.PVC
if sourcePvcSpec == nil {
return nil, errors.New("no source PVC provided")
}
// Find source PVC
sourcePvcNs := sourcePvcSpec.Namespace
if sourcePvcNs == "" {
sourcePvcNs = dataVolume.Namespace
}
pvc := &corev1.PersistentVolumeClaim{}
if err := r.client.Get(context.TODO(), types.NamespacedName{Namespace: sourcePvcNs, Name: sourcePvcSpec.Name}, pvc); err != nil {
if k8serrors.IsNotFound(err) {
r.log.V(3).Info("Source PVC is missing", "source namespace", sourcePvcSpec.Namespace, "source name", sourcePvcSpec.Name)
}
return nil, err
}
return pvc, nil
}
func (r *PvcCloneReconciler) getGlobalCloneStrategyOverride() (*cdiv1.CDICloneStrategy, error) {
cr, err := cc.GetActiveCDI(r.client)
if err != nil {
return nil, err
}
if cr == nil {
return nil, fmt.Errorf("no active CDI")
}
if cr.Spec.CloneStrategyOverride == nil {
return nil, nil
}
r.log.V(3).Info(fmt.Sprintf("Overriding default clone strategy with %s", *cr.Spec.CloneStrategyOverride))
return cr.Spec.CloneStrategyOverride, nil
}
// NewVolumeClonePVC creates a PVC object to be used during CSI volume cloning.
func (r *PvcCloneReconciler) newVolumeClonePVC(dv *cdiv1.DataVolume,
sourcePvc *corev1.PersistentVolumeClaim,
targetPvcSpec *corev1.PersistentVolumeClaimSpec,
pvcName string) (*corev1.PersistentVolumeClaim, error) {
// Override name - might be temporary pod when in transfer
pvcNamespace := dv.Namespace
if dv.Spec.Source.PVC.Namespace != "" {
pvcNamespace = dv.Spec.Source.PVC.Namespace
}
pvc, err := r.newPersistentVolumeClaim(dv, targetPvcSpec, pvcNamespace, pvcName, r.updateAnnotations)
if err != nil {
return nil, err
}
// be sure correct clone method is selected
delete(pvc.Annotations, cc.AnnCloneRequest)
pvc.Annotations[AnnCSICloneRequest] = "true"
// take source size while cloning
if pvc.Spec.Resources.Requests == nil {
pvc.Spec.Resources.Requests = corev1.ResourceList{}
}