Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement standard HasLabel interface #100

Open
mperktold opened this issue Feb 18, 2022 · 0 comments
Open

Implement standard HasLabel interface #100

mperktold opened this issue Feb 18, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@mperktold
Copy link

There is a common interface com.vaadin.flow.component.HasLabel, which is now implemented by all major flow components.

See vaadin/flow#3241 and vaadin/flow-components#956.

The interface is compatible with the signatures of getLabel and setLabel. It's just a matter of declaring that MultiselectComboBox implements HasLabel.

It might even be possible to delete the current implementation, since HasLabel already defines default methods which are mostly equivalent. The only difference is that MultiselectComboBox .setLabel replaces null with an empty string, whereas HasLabel doesn't.

@gatanaso gatanaso added the enhancement New feature or request label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants