From 07ed5b010ad27b1816084b361f06fd0ae6a017ba Mon Sep 17 00:00:00 2001
From: Kyle Mathews <mathews.kyle@gmail.com>
Date: Fri, 14 Oct 2016 15:17:23 -0700
Subject: [PATCH] Disable extracting chunk manifest until AppShell working
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Currently deploying new version of the site breaks with service workers
as the extracted chunk manifest (loaded fresh everytime) doesn't match
the chunk ids used in some of the cached chunks.

At least that's my theory :-)

In any case, I keep seeing this error:

bootstrap 1a2fd54…:50 Uncaught TypeError: Cannot read property 'call' of
undefined

which disappears as soon as I update to the latest service worker or
bypass the service worker.

With the AppShell, everything will stay the same until the user updates
to the new version of the service worker so there shouldn't be more
trouble w/ mismatched module ids.
---
 lib/utils/static-entry.js   | 22 +++++++++++-----------
 lib/utils/webpack.config.js |  8 ++++----
 2 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/lib/utils/static-entry.js b/lib/utils/static-entry.js
index f17318eba1aac..6bca30d832589 100644
--- a/lib/utils/static-entry.js
+++ b/lib/utils/static-entry.js
@@ -40,17 +40,17 @@ module.exports = (locals, callback) => {
       }
 
       // Add the chunk-manifest as a head component.
-      const chunkManifest = require('!raw!public/chunk-manifest.json')
-      headComponents.push(
-        <script
-          id="webpack-manifest"
-          dangerouslySetInnerHTML={{ __html: `
-          //<![CDATA[
-          window.webpackManifest = ${chunkManifest}
-          //]]>
-          `}}
-        />
-      )
+      //const chunkManifest = require('!raw!public/chunk-manifest.json')
+      //headComponents.push(
+        //<script
+          //id="webpack-manifest"
+          //dangerouslySetInnerHTML={{ __html: `
+          ////<![CDATA[
+          //window.webpackManifest = ${chunkManifest}
+          ////]]>
+          //`}}
+        ///>
+      //)
 
       const scripts = [`commons`, `app`]
       // Path chunk.
diff --git a/lib/utils/webpack.config.js b/lib/utils/webpack.config.js
index 5b89dd0b11d3a..5bbf1ed7edd6c 100644
--- a/lib/utils/webpack.config.js
+++ b/lib/utils/webpack.config.js
@@ -217,10 +217,10 @@ module.exports = (program, directory, suppliedStage, webpackPort = 1500, pages =
           // Extract the webpack chunk manifest out of commons.js so commons.js
           // doesn't get changed everytime you build. This increases the cache-hit
           // rate for commons.js.
-          new ChunkManifestPlugin({
-            filename: "chunk-manifest.json",
-            manifestVariable: "webpackManifest"
-          }),
+          //new ChunkManifestPlugin({
+            //filename: "chunk-manifest.json",
+            //manifestVariable: "webpackManifest"
+          //}),
           // Minify Javascript.
           new webpack.optimize.UglifyJsPlugin({
             compress: {