From af87e96e570441ee63d8dc7b714846ca3601bef1 Mon Sep 17 00:00:00 2001
From: Michal Piechowiak <misiek.piechowiak@gmail.com>
Date: Thu, 14 Mar 2019 19:45:21 +0100
Subject: [PATCH] fix(gatsby-transformer-remark): wait for async subplugins
 (#12578)

* move eachPromise to utils file and add (failing) tests

* fix eachPromise
---
 .../src/__tests__/utils.js                    | 24 +++++++++++++++++++
 .../src/extend-node-type.js                   | 14 +----------
 .../gatsby-transformer-remark/src/utils.js    | 12 ++++++++++
 3 files changed, 37 insertions(+), 13 deletions(-)
 create mode 100644 packages/gatsby-transformer-remark/src/__tests__/utils.js
 create mode 100644 packages/gatsby-transformer-remark/src/utils.js

diff --git a/packages/gatsby-transformer-remark/src/__tests__/utils.js b/packages/gatsby-transformer-remark/src/__tests__/utils.js
new file mode 100644
index 0000000000000..909bf72ad3f0a
--- /dev/null
+++ b/packages/gatsby-transformer-remark/src/__tests__/utils.js
@@ -0,0 +1,24 @@
+const { eachPromise } = require(`../utils`)
+
+test(`eachPromise`, async () => {
+  const args = [`foo`, `bar`, `baz`]
+
+  const cb = jest.fn()
+
+  await eachPromise(args, arg => {
+    cb(`Start`, arg)
+    return new Promise(resolve => {
+      setTimeout(() => {
+        cb(`Finish`, arg)
+        resolve()
+      }, 200)
+    })
+  })
+
+  expect(cb).toHaveBeenNthCalledWith(1, `Start`, `foo`)
+  expect(cb).toHaveBeenNthCalledWith(2, `Finish`, `foo`)
+  expect(cb).toHaveBeenNthCalledWith(3, `Start`, `bar`)
+  expect(cb).toHaveBeenNthCalledWith(4, `Finish`, `bar`)
+  expect(cb).toHaveBeenNthCalledWith(5, `Start`, `baz`)
+  expect(cb).toHaveBeenNthCalledWith(6, `Finish`, `baz`)
+})
diff --git a/packages/gatsby-transformer-remark/src/extend-node-type.js b/packages/gatsby-transformer-remark/src/extend-node-type.js
index e314ce2a7c488..e976a1c4f6af6 100644
--- a/packages/gatsby-transformer-remark/src/extend-node-type.js
+++ b/packages/gatsby-transformer-remark/src/extend-node-type.js
@@ -29,6 +29,7 @@ const {
   cloneTreeUntil,
   findLastTextNode,
 } = require(`./hast-processing`)
+const { eachPromise } = require(`./utils`)
 
 let fileNodes
 let pluginsCacheStr = ``
@@ -68,19 +69,6 @@ const safeGetCache = ({ getCache, cache }) => id => {
   return getCache(id)
 }
 
-/**
- * @template T
- * @param {Array<T>} input
- * @param {(input: T) => Promise<void>} iterator
- * @return Promise<void>
- */
-const eachPromise = (input, iterator) =>
-  input.reduce(
-    (accumulatorPromise, nextValue) =>
-      accumulatorPromise.then(() => void iterator(nextValue)),
-    Promise.resolve()
-  )
-
 const HeadingType = new GraphQLObjectType({
   name: `MarkdownHeading`,
   fields: {
diff --git a/packages/gatsby-transformer-remark/src/utils.js b/packages/gatsby-transformer-remark/src/utils.js
new file mode 100644
index 0000000000000..39456e299c311
--- /dev/null
+++ b/packages/gatsby-transformer-remark/src/utils.js
@@ -0,0 +1,12 @@
+/**
+ * @template T
+ * @param {Array<T>} input
+ * @param {(input: T) => Promise<void>} iterator
+ * @return Promise<void>
+ */
+exports.eachPromise = (input, iterator) =>
+  input.reduce(
+    (accumulatorPromise, nextValue) =>
+      accumulatorPromise.then(() => iterator(nextValue)),
+    Promise.resolve()
+  )