BUG: gatsby-plugin-google-analytics is getting an undefined pathname

[camsjams]

Currently the code does this:

exports.onRouteUpdate = function(location) {
  // Don't track while developing.
  if (process.env.NODE_ENV === `production`) {
    ga(`set`, `page`, location.pathname)
    ga(`send`, `pageview`)
  }
}

But it appears as though the parameter called location is structured like so:

{
	location: {
		pathname: '/home',
		search: '',
		hash: '',
		key: 'q8junx'
	},
	action: 'PUSH'
}

The resulting bug is that we get production code doing something like:

 ga('set', 'page', undefined);

Causing the GA metrics to show whatever the first SSR-served landing page to be the page viewed many times over (because page will never change).

Pretty easy change, but I am assuming this must have worked before?

Versions:
node v8.0.0
gatsby@1.0.0-beta.5
gatsby-plugin-google-analytics@1.0.0-beta.1

[KyleAMathews]

Oh wow... yeah the plugin is really outdated :-( the API got updated a while ago https://www.gatsbyjs.org/docs/browser-apis/#onRouteUpdate

[KyleAMathews]

could you submit a quick PR for this? I'm making a new release this afternoon so could get this out then.

[camsjams]

Sure thing, though I have found a secondary issue as well, you will see in PR.

[KyleAMathews]

Fixed in #1318