Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-google-tagmanager): Allow to place the GTM script … #13424

Merged
merged 3 commits into from
Apr 18, 2019

Conversation

NoriSte
Copy link
Contributor

@NoriSte NoriSte commented Apr 17, 2019

…at the end of the tag

Description

I added one more option to the gatsby-plugin-google-tagmanager plugin to allow adding the GTM script in the head (by default, as it is now) or append it to the body (to make it non-blocking).

Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this @NoriSte 👍

Left a small comment!

packages/gatsby-plugin-google-tagmanager/README.md Outdated Show resolved Hide resolved
@sidharthachatterjee sidharthachatterjee added the status: awaiting author response Additional information has been requested from the author label Apr 18, 2019
@sidharthachatterjee sidharthachatterjee merged commit 0b56c3b into gatsbyjs:master Apr 18, 2019
@gatsbot
Copy link

gatsbot bot commented Apr 18, 2019

Holy buckets, @NoriSte — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@NoriSte
Copy link
Contributor Author

NoriSte commented Apr 19, 2019

Is the NPM release of the plugin automatic? Do you know when it could happen? To know when I can discard my changes and re-download the official one. 😊

sidharthachatterjee added a commit that referenced this pull request Apr 19, 2019
sidharthachatterjee added a commit that referenced this pull request Apr 19, 2019
@sidharthachatterjee
Copy link
Contributor

@NoriSte Releases are manual at the moment and requires one of us from the core team to publish.

I've reverted this in #13424 because @wardpeet correctly pointed out that since the script is always added async, this doesn't really have any impact and hence it's best that we don't add another option.

Nonetheless, thank you again for your contribution and sorry for the confusion!

@NoriSte
Copy link
Contributor Author

NoriSte commented Apr 19, 2019

I need some more investigations because I got (obviously as it seems) wrong feedbacks from my first tests. I'll let you know as soon as I find out something more.
Anyway: don't worry and sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting author response Additional information has been requested from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants