-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-plugin-google-tagmanager): Allow to place the GTM script … #13424
Conversation
…at the end of the <body> tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this @NoriSte 👍
Left a small comment!
Holy buckets, @NoriSte — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Is the NPM release of the plugin automatic? Do you know when it could happen? To know when I can discard my changes and re-download the official one. 😊 |
@NoriSte Releases are manual at the moment and requires one of us from the core team to publish. I've reverted this in #13424 because @wardpeet correctly pointed out that since the script is always added Nonetheless, thank you again for your contribution and sorry for the confusion! |
I need some more investigations because I got (obviously as it seems) wrong feedbacks from my first tests. I'll let you know as soon as I find out something more. |
…at the end of the tag
Description
I added one more option to the
gatsby-plugin-google-tagmanager
plugin to allow adding the GTM script in the head (by default, as it is now) or append it to the body (to make it non-blocking).