Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-offline): Drop preload link for json from offline shell #13935

Merged
merged 1 commit into from
May 17, 2019

Conversation

@DSchau DSchau added the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label May 13, 2019
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Not going to block this, so let's merge tomorrow--but had you thought about perhaps adding some type of test (we have some offline plugin tests in e2e-tests/production-runtime) to validate that this stays fixed?

@sidharthachatterjee sidharthachatterjee removed the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label May 17, 2019
@sidharthachatterjee sidharthachatterjee merged commit d1f0ae6 into gatsbyjs:master May 17, 2019
@gatsbot
Copy link

gatsbot bot commented May 17, 2019

Holy buckets, @hupe1980 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment