fix(gatsby-plugin-google-tagmanager): Properly communicate site title with GTM services #14384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w to register events in GTM
|
This failure is odd -- installing packages and running tests works great locally. Any ideas on what's happening? |
This is probably network error / flake and we can ignore it for now (will restart tests before merging) |
pieh
reviewed
May 29, 2019
|
@pieh 0ms timeout was still mismatching title/route occasionally, so I upped it to 50ms to be safe. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR registers a Google Tag Manager event that will fire whenever the route in a Gatsby application changes. This fixes a previously described issue (#13968) which led to weird mismatched site titles and routes in Google Analytics. It also updates the documentation to give an example of how to use this event in your Google Analytics to detect Gatsby route changes.
I'm somewhat new to production-level JS development and I know this may not be entirely optimal (the 2000ms delay especially, it was just a number that seemed reasonable since some delay was necessary), so let me know what I can do to make this better!
Related Issues
Fixes #13968