-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-plugin-mdx): Fix graphql query examples in readme #15691
fix(gatsby-plugin-mdx): Fix graphql query examples in readme #15691
Conversation
Follow schema change from gatsbyjs@19f7396
@CrashWire I was just looking into this! You might want to also update the two other places in the docs where it’s mentioned to make sure the change is complete :) In your commit, that’s line 443 (where it’s consumed from the query) and line 433 (where it’s mentioned in the context of additional props) |
@mrozilla Thanks for helping spot the omissions! I’ve made the changes in 35c12f5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I've stumbled upon this myself. One small question added. Besides that, this looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I've stumbled upon this myself. One small question added. Besides that, this looks great.
Co-Authored-By: Ward Peeters <ward@coding-tech.com>
@wardpeet That seems to be right! (I was also trying to figure out if @ChristopherBiscardi might have had a reason to include the beginning |
Holy buckets, @CrashWire — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
…s#15691) * Update gatsby-plugin-mdx readme example Follow schema change from gatsbyjs@19f7396 * Update gatsby-plugin-mdx readme example with missed changes * Fix gatsby-plugin-mdx readme’s MDXRenderer example Co-Authored-By: Ward Peeters <ward@coding-tech.com> * prettier update
Description
19f7396 breaks the example provided in the readme. This updates the readme to fix it.