-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade webpack version #15775
Comments
nice, now I can upgrade #14792 again |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open! As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contributefor more information about opening PRs, triaging issues, and contributing! Thanks for being a part of the Gatsby community! 💪💜 |
For impatient user: |
It's not really, we need to bump higher but we're currently stuck with an upstream bug so i'm re-opening. Currently waiting for https://github.com/geowarin/friendly-errors-webpack-plugin/tree/v2.0.0-beta.2 to get out of beta. |
Hey again! It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it. Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing! Thanks again for being part of the Gatsby community! |
Description
Gatsby fix webpack version at
~4.28.4
in this commit, because there is an regression in webpack 4.29.But now that regression is fixed. It should be ok to use
4.35.x
or later.Some newer plugin expect webpack's finishModules hook to be
AsyncSeriesHook
. But in webpack~4.28.4, it is a SyncHook, which will complaintapPromise is not supported on a SyncHook
and cause a build failure.Expected result
We should use newer webpack version.
Actual result
Webpack version is fixed at
4.28.x
.Environment
all
The text was updated successfully, but these errors were encountered: