Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade webpack version #15775

Closed
csr632 opened this issue Jul 16, 2019 · 6 comments
Closed

upgrade webpack version #15775

csr632 opened this issue Jul 16, 2019 · 6 comments
Labels
stale? Issue that may be closed soon due to the original author not responding any more. type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change type: upstream Issues outside of Gatsby's control, caused by dependencies

Comments

@csr632
Copy link
Contributor

csr632 commented Jul 16, 2019

Description

Gatsby fix webpack version at ~4.28.4 in this commit, because there is an regression in webpack 4.29.
But now that regression is fixed. It should be ok to use 4.35.x or later.

Some newer plugin expect webpack's finishModules hook to be AsyncSeriesHook. But in webpack~4.28.4, it is a SyncHook, which will complain tapPromise is not supported on a SyncHook and cause a build failure.

Expected result

We should use newer webpack version.

Actual result

Webpack version is fixed at 4.28.x.

Environment

all

@wardpeet
Copy link
Contributor

nice, now I can upgrade #14792 again

@m-allanson m-allanson added the type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change label Jul 16, 2019
@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Aug 6, 2019
@gatsbot
Copy link

gatsbot bot commented Aug 6, 2019

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contributefor more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@csr632
Copy link
Contributor Author

csr632 commented Aug 16, 2019

For impatient user: npm install gatsby@webpack-acorn
This tag use latest webpack.

@sidharthachatterjee
Copy link
Contributor

We're now at ~4.39.2 so this should good to close.

Further updates to dependencies are tracked in #16840

@wardpeet
Copy link
Contributor

wardpeet commented Sep 2, 2019

It's not really, we need to bump higher but we're currently stuck with an upstream bug so i'm re-opening.

Currently waiting for https://github.com/geowarin/friendly-errors-webpack-plugin/tree/v2.0.0-beta.2 to get out of beta.

@wardpeet wardpeet reopened this Sep 2, 2019
@wardpeet wardpeet added the type: upstream Issues outside of Gatsby's control, caused by dependencies label Sep 2, 2019
@gatsbot
Copy link

gatsbot bot commented Sep 13, 2019

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community!

@gatsbot gatsbot bot closed this as completed Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more. type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change type: upstream Issues outside of Gatsby's control, caused by dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants