add a bunch of tests for various plugins #1581
Conversation
|
Deploy preview ready! Built with commit c03932e |
|
Deploy preview ready! Built with commit c03932e |
|
Deploy preview ready! Built with commit c03932e |
|
Deploy preview ready! Built with commit e81cd72 |
|
Deploy preview ready! Built with commit e81cd72 |
|
Deploy preview ready! Built with commit e81cd72 |
|
Deploy preview failed. Built with commit ad15acc https://app.netlify.com/sites/using-contentful/deploys/597790897960b1659463eead |
|
This is so cool! A tests PR, amazing :-) Sorry for the slow response — does not reflect my appreciation of this PR :-) Been out on vacation. Going to merge from master to re-run tests. Looks like tests failed on Windows? |
|
@KyleAMathews hope the vacay was great, much deserved! As for this PR, I haven't taken a look at it since I pushed it up, but I'll see if I can take another look tonight! As far as Windows support goes, I wouldn't think there'd be any regressions with Mac v. Windows, so hopefully that's not the case! |
|
Deploy preview failed. Built with commit ad15acc https://app.netlify.com/sites/image-processing/deploys/597790897960b1659463eea4 |
|
Deploy preview failed. Built with commit ad15acc https://app.netlify.com/sites/using-glamor/deploys/597790897960b1659463eea7 |
|
Deploy preview failed. Built with commit ad15acc https://app.netlify.com/sites/using-styled-components/deploys/597790897960b1659463eeaa |
|
Yeah seems like there's a few problems with windows https://ci.appveyor.com/project/KyleAMathews/gatsby/build/1.0.1400/job/s5r1kblirawji3uh#L526 4 failing tests in copy-linked-files. |
|
Yikes! Well I'll take a look and see if I can't get that figured out |
|
Pretty sure the issue is with this line here, which is causing this check to fail on Windows. I think Not sure which is better. Gonna try path.normalize first. |
|
Whew, that did fix it! Should be good to go now |
|
Awesome! Thanks! |
* test: add test scaffolding for plugins * test: add a simple test for navigateTo * test: add a bunch of tests * style: run prettier on tests * test: fix broken absolute url * test: fix equality check * test: (hopefully) fix issue with windows
Added a bunch of tests to serve as a baseline for expected functionality.
Let me know if you'd like any further detail!