Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-transformer-remark): subscribe to mimeTypes in type definitions #16172

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Jul 28, 2019

Built on top of features added in #15715

This should be no-op on older versions of Gatsby that don't support @childOf directive and not cause any unknown API situation.

/cc @stefanprobst Let me know if this is correct - it does seem to work and create childMarkdownRemark fields (when parent node types have @mimeTypes directive/extension)

@pieh pieh requested a review from a team as a code owner July 28, 2019 18:14
@pieh pieh requested a review from stefanprobst July 28, 2019 18:14
Copy link
Contributor

@stefanprobst stefanprobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@wardpeet wardpeet merged commit d80c273 into gatsbyjs:master Jul 29, 2019
@wardpeet
Copy link
Contributor

Published in gatsby-transformer-remark@2.6.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants