Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-plugin-offline): Allow precaching custom pages #16877

Merged
merged 50 commits into from
Sep 4, 2019
Merged

feat(gatsby-plugin-offline): Allow precaching custom pages #16877

merged 50 commits into from
Sep 4, 2019

Conversation

vtenfys
Copy link
Contributor

@vtenfys vtenfys commented Aug 21, 2019 •
edited
Loading

Description

Add an option precachePages to gatsby-plugin-offline to allow adding resources for specified pages to the service worker precache.

Related Issues

Closes #16431

Additional Notes

Includes changes of #11626 since the plugin options need to be separated from Workbox options in both PRs, and it's assumed we will merge that one first

David Bailey and others added 20 commits February 7, 2019 17:05
Allow injection into sw.js
3f076f1
Bump version + give example
2a73939
Merge branch 'master' into offline-plugin-custom-code
2080a64
Catch missing offline inject script
487e236
Merge branch 'master' into offline-plugin-custom-code
ce87669
Update README for migration to v3 + precachePages option
4bb5d56
Merge branch upstream/master into offline-plugin-custom-code
85c5f38
reorganise readme slightly
ffd8a5e
upgrade workbox to v4
e5465f5
injectScript -> appendScript
97892f6
Add tests for sw append
e75af66
Merge branch upstream/master into offline-plugin-custom-code
aa26a01
@vtenfys @sidharthachatterjee
Update packages/gatsby-plugin-offline/README.md
85075fa 
Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>
fix deprecation warnings
869c2a4
Merge branch 'offline-plugin-custom-code' of github.com:davidbailey00…
ebeeeb3 
…/gatsby into offline-plugin-custom-code
Update docs to mention Workbox v3->v4
fec21e1
@sidharthachatterjee
Update yarn.lock
473a548
Merge branch 'master' into offline-plugin-custom-code
8037c1b
Merge branch 'master' into offline-precache-custom-pages
6b5b8e4
Merge branch 'offline-plugin-custom-code' into offline-precache-custo…
1aa361f 
…m-pages
@vtenfys vtenfys requested review from a team as code owners August 21, 2019 09:45
@vtenfys
Copy link
Contributor Author

vtenfys commented Aug 21, 2019

getResourcesFromHTML not working properly in tests, looks like I've broken that in some cases with the pathPrefix usage changes

eknowles
eknowles reviewed Aug 24, 2019
View reviewed changes
packages/gatsby-plugin-offline/README.md Outdated
]
```

# <<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a merge issue here?

@sidharthachatterjee sidharthachatterjee added breaking change If implemented, this proposed work would break functionality for older versions of Gatsby status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged and removed breaking change If implemented, this proposed work would break functionality for older versions of Gatsby labels Aug 29, 2019
@sidharthachatterjee
Copy link
Contributor

Blocked by #11626

@vtenfys vtenfys removed the status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged label Sep 4, 2019
pieh
pieh approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vtenfys vtenfys merged commit 12b5f75 into gatsbyjs:master Sep 4, 2019
waltercruz pushed a commit to waltercruz/gatsby that referenced this pull request Sep 8, 2019
@vtenfys @waltercruz
feat(gatsby-plugin-offline): Allow precaching custom pages (gatsbyjs#…
455db0b 
…16877)

* Allow precaching custom pages rather than just the offline shell
* Document this and add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eknowles eknowles eknowles left review comments

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache all the pages and assets
4 participants
@vtenfys @sidharthachatterjee @pieh @eknowles