Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-offline): set path resources on route update to ensure initial page is cached #17408

Merged
merged 1 commit into from
Sep 6, 2019
Merged

fix(gatsby-plugin-offline): set path resources on route update to ensure initial page is cached #17408

merged 1 commit into from
Sep 6, 2019

Conversation

vtenfys
Copy link
Contributor

@vtenfys vtenfys commented Sep 5, 2019

Description

Ensure that the initial page (usually /) is cached, not just pages linked via that page - the initial page does not receive an onPostPrefetchPathname API call so currently it is not being cached.

@vtenfys vtenfys requested a review from a team as a code owner September 5, 2019 10:33
@vtenfys vtenfys added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Sep 5, 2019
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@gatsbybot gatsbybot merged commit 556c4cf into gatsbyjs:master Sep 6, 2019
waltercruz pushed a commit to waltercruz/gatsby that referenced this pull request Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants