feat(gatsby-plugin-offline): Allow configuring Workbox debug mode #18123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh my, I didn't test it but it seems like we do lots of hacky stuff with workbox so i'm okay with approving after this is working. I wonder if we should switch to https://developers.google.com/web/tools/workbox/modules/workbox-build#injectmanifest instead of generateSw |
wardpeet
added
the
status: awaiting author response
|
The reason we use Also I wish there were a less hacky way of doing this, but Workbox doesn't allow configuring this option when using either |
m-allanson
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new
debugoption to configure Workbox's debugging logsRelated Issues
Fixes #17782