fix(gatsby-plugin-offline): Improve reliability of JS detection #18760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardpeet
reviewed
Oct 24, 2019
pieh
approved these changes
Nov 4, 2019
There was a problem hiding this comment.
This is great, thanks!
Additional improvement could to try to make use of request.referrer if available over lastNavigationRequest (which can have unlikely timing issues given that it is global variable that can be changed by unrelated request in different tab or so):
But this might introduce additional edge cases, so we should merge this in and research potential usage of referrer in follow up
pieh
added
the
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses a similar but slightly different approach to JS disabled detection, which doesn't rely on preload working. Fixes issue with the API not being called on Firefox.