fix(gatsby): Handle special characters in windows paths #19600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidharthachatterjee
added
the
bot: merge on green
|
Published in |
15 tasks
This was referenced Sep 22, 2022
2 tasks
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses several issues on Windows with paths containing special characters. The source of some of those issues is a
slashpackage which explicitly declares that it only works with ASCII paths (see sindresorhus/slash#5).We already have a PR addressing one specific issue in
gatsby-source-filesystem(#14372) but many places are affected (including core gatsby package).This PR moves
slashutil intogatsby-core-utilsand replacesslashusages.It also fixes an issue with invalid GraphQL query names generated from such paths, see #4565 (comment).
P.S. Not sure what would be the right PR name when it affects multiple packages from monorepo?
Related Issues
#4565
#13882
#13865
#14126
#17746
#17746
#19108