Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrap ignore pattern in quotes #23176

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

LekoArts
Copy link
Contributor

Description

So I've been seeing a reoccurring issue with the Gatsby monorepo on my local Windows (WSL) dev environment. When I ran yarn bootstrap the babel cli created files at packages/gatsby-source-graphql/batching/__tests__ even though __tests__ should be ignored.

The issue was zsh (my shell) and it already appeared in this previous PR: #14465

So I'm adding this to every script so that people don't accidentally commit files that should be ignored / not be generated via Babel. In the past I always had to exclude/delete those files first which is annoying and you can easily forget it.

Related Issues

#14465

@LekoArts LekoArts requested a review from a team as a code owner April 16, 2020 13:58
Copy link
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thanks for going through and hunting down all of these! Are there any tests we can add around this to catch anything added in the future?

@blainekasten
Copy link
Contributor

I'm going to merge this as is. The downsides of this are relatively little so I am okay with skipping tests on it.

@blainekasten blainekasten merged commit 7563db6 into gatsbyjs:master Apr 16, 2020
@LekoArts LekoArts deleted the wrap-ignore-pattern branch April 17, 2020 07:01
mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants