Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gatsby-source-contentful without dependency on gatsby-plugin-sharp #23904

Closed
just-boris opened this issue May 8, 2020 · 0 comments
Closed

gatsby-source-contentful without dependency on gatsby-plugin-sharp #23904

just-boris opened this issue May 8, 2020 · 0 comments
Assignees
Labels
topic: source-contentful Related to Gatsby's integration with Contentful type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement.

Comments

@just-boris
Copy link
Contributor

Summary

Currently, it is not possible to install Contentful source without getting Sharp plugin. This introduces a few issues

The issues above are very frustrating when you don't have any images, so you have to deal with the issues for nothing.

Proposed change

Move gatsby-plugin-sharp to optionalDependencies of gatsby-source-contentful. The change is backward-compatible, the package will be installed anyway, however, if the installation of this module fails, the build will proceed anyway.

@just-boris just-boris added the type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement. label May 8, 2020
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 8, 2020
@pvdz pvdz removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 8, 2020
@wardpeet wardpeet added the topic: source-contentful Related to Gatsby's integration with Contentful label May 13, 2020
just-boris added a commit to just-boris/gatsby that referenced this issue May 16, 2020
axe312ger added a commit to axe312ger/gatsby that referenced this issue Oct 2, 2020
axe312ger added a commit to axe312ger/gatsby that referenced this issue Oct 2, 2020
@pvdz pvdz closed this as completed in 7bf2bdb Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-contentful Related to Gatsby's integration with Contentful type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants