-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gatsby-source-contentful without dependency on gatsby-plugin-sharp #23904
Labels
topic: source-contentful
Related to Gatsby's integration with Contentful
type: feature or enhancement
Issue that is not a bug and requests the addition of a new feature or enhancement.
Comments
just-boris
added
the
type: feature or enhancement
Issue that is not a bug and requests the addition of a new feature or enhancement.
label
May 8, 2020
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
May 8, 2020
pvdz
removed
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
May 8, 2020
wardpeet
added
the
topic: source-contentful
Related to Gatsby's integration with Contentful
label
May 13, 2020
just-boris
added a commit
to just-boris/gatsby
that referenced
this issue
May 16, 2020
axe312ger
added a commit
that referenced
this issue
Jun 30, 2020
axe312ger
added a commit
that referenced
this issue
Jun 30, 2020
axe312ger
added a commit
that referenced
this issue
Jul 8, 2020
axe312ger
added a commit
that referenced
this issue
Jul 8, 2020
axe312ger
added a commit
that referenced
this issue
Jul 8, 2020
axe312ger
added a commit
that referenced
this issue
Jul 17, 2020
axe312ger
added a commit
that referenced
this issue
Jul 29, 2020
axe312ger
added a commit
that referenced
this issue
Aug 5, 2020
axe312ger
added a commit
to axe312ger/gatsby
that referenced
this issue
Oct 2, 2020
axe312ger
added a commit
to axe312ger/gatsby
that referenced
this issue
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: source-contentful
Related to Gatsby's integration with Contentful
type: feature or enhancement
Issue that is not a bug and requests the addition of a new feature or enhancement.
Summary
Currently, it is not possible to install Contentful source without getting Sharp plugin. This introduces a few issues
gatsby-plugin-sharp
package depends on packages with tricky licensing – Incompatible Licenses Apache2.0 & GPLv2 (gatsby-plugin-sharp) #17584. Since it is a required dependency ofgatsby-source-contentful
, this package itself has licensing issues.The issues above are very frustrating when you don't have any images, so you have to deal with the issues for nothing.
Proposed change
Move
gatsby-plugin-sharp
tooptionalDependencies
ofgatsby-source-contentful
. The change is backward-compatible, the package will be installed anyway, however, if the installation of this module fails, the build will proceed anyway.The text was updated successfully, but these errors were encountered: