Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-offline): versioned import of idb-keyval #24938

Merged
merged 3 commits into from
Jun 18, 2020
Merged

fix(gatsby-plugin-offline): versioned import of idb-keyval #24938

merged 3 commits into from
Jun 18, 2020

Conversation

nibtime
Copy link
Contributor

@nibtime nibtime commented Jun 11, 2020

Fixes #24936

@nibtime
fix(sw): versioned import of idb-keyval
ed7c887 
with the version included it is ok to cache it immutable alongside the other fingerprinted js files produced by Gatsby
@nibtime nibtime requested a review from a team as a code owner June 11, 2020 23:12
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 11, 2020
@ascorbic
Copy link
Contributor

Hi. Thanks for the PR. This is failing tests at the moment. Looks like something wrong with imports. Could you check and see if you can get them to pass. Thanks.

@ascorbic ascorbic added status: awaiting author response Additional information has been requested from the author and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 16, 2020
@ascorbic ascorbic requested a review from pvdz June 18, 2020 09:15
@ascorbic ascorbic added topic: plugins-PWA Issues related to PWA: the gatsby-plugin-offline and gatsby-plugin-manifest plugins status: needs core review Currently awaiting review from Core team member and removed status: awaiting author response Additional information has been requested from the author labels Jun 18, 2020
pvdz
pvdz approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you 💜

@pvdz pvdz changed the title fix(sw): versioned import of idb-keyval fix(gatsby-plugin-offline): versioned import of idb-keyval Jun 18, 2020
@pvdz pvdz added type: bug An issue or pull request relating to a bug in Gatsby bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: needs core review Currently awaiting review from Core team member labels Jun 18, 2020
@gatsbybot gatsbybot merged commit 13aaa16 into gatsbyjs:master Jun 18, 2020
@gatsbot
Copy link

gatsbot bot commented Jun 18, 2020

Holy buckets, @nibtime — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot
fix(gatsby-plugin-offline): versioned import of idb-keyval (gatsbyjs#…
8b3d035 
…24938)

* fix(sw): versioned import of idb-keyval

with the version included it is ok to cache it immutable alongside the other fingerprinted js files produced by Gatsby

* style: fix linting errors

* fix(sw): replace versioned import in sw-append.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvdz pvdz pvdz approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: plugins-PWA Issues related to PWA: the gatsby-plugin-offline and gatsby-plugin-manifest plugins type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gatsby-plugin-offline]: Potential for caching problems with idb-keyval
4 participants
@nibtime @ascorbic @pvdz @gatsbybot