Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move webpackManifest to below body #2541

Closed
KyleAMathews opened this issue Oct 20, 2017 · 5 comments
Closed

Move webpackManifest to below body #2541

KyleAMathews opened this issue Oct 20, 2017 · 5 comments

Comments

@KyleAMathews
Copy link
Contributor

It can get quite large on big sites so blocks the initial render.

We'd need to revisit how to ensure webpack doesn't start working until this is read in.

Requested in reactjs/react.dev#179

@Daniel15
Copy link
Contributor

Daniel15 commented Oct 20, 2017

how to ensure webpack doesn't start working until this is read in.

I'm not very experienced with Webpack, but won't everything "just work" if all the JS is at the bottom of the body, as long as this manifest is above all the other JS? Since Gatsby sites work without JS (I assume), it would make sense to defer as much of it as possible.

@KyleAMathews
Copy link
Contributor Author

eh probably :-) I haven't thought about this stuff for 6 months so I'd need to research to remember why I moved it back to the top.

But yeah, I don't think this is a very hard fix.

@szimek
Copy link
Contributor

szimek commented Nov 20, 2017

@KyleAMathews What exactly is this webpackManifest used for? Does it list all pages? We're planning to use Gatsby and Contentful to run a blog with ~5000 pages, so it will probably get quite huge - assuming a single entry is ~60 bytes, it will be additional ~300kB on each page?

@szimek
Copy link
Contributor

szimek commented Jan 15, 2018

@KyleAMathews This issue can be closed now thanks to #3519.

@KyleAMathews
Copy link
Contributor Author

@szimek thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants