Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-offline): Update regex to catch new static query results #26329

Merged
merged 2 commits into from
Aug 10, 2020
Merged

fix(gatsby-plugin-offline): Update regex to catch new static query results #26329

merged 2 commits into from
Aug 10, 2020

Conversation

sidharthachatterjee
Copy link
Contributor

As a result of #26242, static query results are now stored in /public/page-data/sq/

This PR adjusts the glob in gatsby-plugin-offline so that caches these files as well.

@sidharthachatterjee sidharthachatterjee requested a review from a team as a code owner August 10, 2020 10:43
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 10, 2020
@sidharthachatterjee sidharthachatterjee added type: bug An issue or pull request relating to a bug in Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 10, 2020
@gatsbyjs gatsbyjs deleted a comment from gatsby-cloud-staging bot Aug 10, 2020
@gatsbyjs gatsbyjs deleted a comment from gatsby-cloud bot Aug 10, 2020
@gatsbyjs gatsbyjs deleted a comment from gatsby-cloud bot Aug 10, 2020
@gatsbyjs gatsbyjs deleted a comment from gatsby-cloud bot Aug 10, 2020
wardpeet
wardpeet suggested changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you augment the comment and also you should be able to remove

      {
        // app-data.json is not content hashed
        urlPattern: /^https?:.*\/page-data\/app-data\.json/,
        handler: `StaleWhileRevalidate`,
      },

packages/gatsby-plugin-offline/src/gatsby-node.js Outdated
@@ -140,7 +140,7 @@ exports.onPostBuild = (
},
{
// page-data.json files are not content hashed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// page-data.json files are not content hashed
// Files inside page-data folder are not content hashed (page-data, app-data, static-queries).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes. Great catch!

sidharthachatterjee added a commit to devfive/gatsby that referenced this pull request Aug 10, 2020
@sidharthachatterjee
Update for gatsbyjs#26329
11a567c
@sidharthachatterjee sidharthachatterjee mentioned this pull request Aug 10, 2020
Merged
@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 10, 2020

Gatsby Cloud Build Report

gatsby

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 36m

wardpeet
wardpeet approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks works as expected!

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Aug 10, 2020
@gatsbybot gatsbybot merged commit 75ab9b8 into master Aug 10, 2020
gatsbybot pushed a commit that referenced this pull request Aug 10, 2020
@devfive @sidharthachatterjee
docs: Updated gatsby-plugin-offline README with correct default workb…
a5c76fc 
…ox config (#26295)

* Updated gatsby-plugin-offline README with correct default workbox config

* Update for #26329

Co-authored-by: Sidhartha Chatterjee <me@sidharthachatterjee.com>
@LekoArts LekoArts deleted the fix/static-queries-caching branch November 9, 2020 08:27
@kije kije mentioned this pull request Nov 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sidharthachatterjee @wardpeet @gatsbybot