fix(gatsby-plugin-page-creator): juggle reporter dont depend on cli #26357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Gatsby Cloud Build Report🚩 Your build failed. See the build logs here Errors Error in "/usr/src/app/www/www/node_modules/gatsby-plugin-page-creator/gatsby-node.js": Cannot find module 'gatsby-cli/lib/reporter' Require stack: - /usr/src/app/www/www/node_modules/gatsby-plugin-page-creator/is-valid-collection-path-implementation.js - /usr/src/app/www/www/node_modules/gatsby-plugin-page-creator/create-pages-from-collection-builder.js - /usr/src/app/www/www/node_modules/gatsby-plugin-page-creator/create-page-wrapper.js - /usr/src/app/www/www/node_modules/gatsby-plugin-page-creator/gatsby-node.js - /usr/src/app/www/www/node_modules/gatsby/dist/bootstrap/resolve-module-exports.js - /usr/src/app/www/www/node_modules/gatsby/dist/bootstrap/load-plugins/validate.js - /usr/src/app/www/www/node_modules/gatsby/dist/bootstrap/load-plugins/load.js - /usr/src/app/www/www/node_modules/gatsby/dist/bootstrap/load-plugins/index.js - /usr/src/app/www/www/node_modules/gatsby/dist/services/initialize.js - /usr/src/app/www/www/node_modules/gatsby/dist/services/index.js - /usr/src/app/www/www/node_modules/gatsby/dist/bootstrap/index.js - /usr/src/app/www/www/node_modules/gatsby/dist/commands/build.js - /usr/src/app/www/www/node_modules/gatsby/node_modules/gatsby-cli/lib/create-cli.js - /usr/src/app/www/www/node_modules/gatsby/node_modules/gatsby-cli/lib/index.js - /usr/src/app/www/www/node_modules/gatsby/dist/bin/gatsby.js - /usr/src/app/www/www/node_modules/gatsby/cli.js |
Gatsby Cloud Build Report🚩 Your build failed. See the build logs here Errors Error in "/usr/src/app/www/examples/gatsbygram/node_modules/gatsby-plugin-page-creator/gatsby-node.js": Cannot find module 'gatsby-cli/lib/reporter' Require stack: - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby-plugin-page-creator/is-valid-collection-path-implementation.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby-plugin-page-creator/create-pages-from-collection-builder.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby-plugin-page-creator/create-page-wrapper.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby-plugin-page-creator/gatsby-node.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/bootstrap/resolve-module-exports.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/bootstrap/load-plugins/validate.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/bootstrap/load-plugins/load.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/bootstrap/load-plugins/index.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/services/initialize.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/services/index.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/bootstrap/index.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/commands/build.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/node_modules/gatsby-cli/lib/create-cli.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/node_modules/gatsby-cli/lib/index.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/dist/bin/gatsby.js - /usr/src/app/www/examples/gatsbygram/node_modules/gatsby/cli.js |
sidharthachatterjee
previously approved these changes
Aug 11, 2020
packages/gatsby-plugin-page-creator/src/is-valid-collection-path-implementation.ts
Show resolved
Hide resolved
pvdz
added
type: bug
pvdz
added
the
bot: merge on green
|
Published in |
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…atsbyjs#26357) * fix(gatsby-plugin-page-creator): juggle reporter rather than depend on cli * Add missing reporter type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue where something was imported from
gatsby-cliwithout depending on it.We'd rather not have a plugin depend on the cli directly and since the
reporteris already passed on into it we'd rather juggle it forward.Fixes #26345