fix(gatsby-plugin-sharp): ignore incorrect duotone options #28999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
reviewed
Jan 12, 2021
Co-authored-by: Matt Kane <matt@gatsbyjs.com>
laurieontech
previously approved these changes
Jan 12, 2021
laurieontech
added
topic: media
ascorbic
suggested changes
Jan 12, 2021
|
You can't rely on logging in process-file though, because when running in Cloud you can't see those errors. I think the best bet is to also check in image-data.ts, early on. |
|
Oh wow, I thought that is where this was. Wake up me. |
laurieontech
added
the
bot: merge on green
This was referenced Mar 13, 2021
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…28999) * fix(gatsby-plugin-sharp): ignore incorrect duotone options * Update packages/gatsby-plugin-sharp/src/index.js Co-authored-by: Matt Kane <matt@gatsbyjs.com> * Update index.js * add warning for invalid duotone options Co-authored-by: Matt Kane <matt@gatsbyjs.com> Co-authored-by: Laurie <laurie@gatsbyjs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes people wrongly specifying
duotonewithout a highlight/shadow by ignoring the option and warning the user that it was ignored.[ch22572]