chore: Fix our internal eslint config for monorepo #29795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
added
the
type: maintenance
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
ascorbic
approved these changes
Feb 26, 2021
|
Yeah, we'll need to use a custom regex: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/naming-convention.md#custom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eslint config for our monorepo was in a broken state, which led to my IDE complaining about it and the affected rules not working.
Since
naming-conventionnow works I had to change stuff a bit. I just wanted the errors to go away, didn't fix any. We should do that sometime later and actually enforce our styleguide.