Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatsby-plugin-image - GatsbyImage not displaying image in IE11 #30053

Closed
hazuremon opened this issue Mar 6, 2021 · 11 comments · Fixed by #33416
Closed

Gatsby-plugin-image - GatsbyImage not displaying image in IE11 #30053

hazuremon opened this issue Mar 6, 2021 · 11 comments · Fixed by #33416
Assignees
Labels
stale? Issue that may be closed soon due to the original author not responding any more. topic: media Related to gatsby-plugin-image, or general image/media processing topics type: bug An issue or pull request relating to a bug in Gatsby

Comments

@hazuremon
Copy link

Description

Upgrading from Gatsby-image to Gatsby-Plugin-Image, currently in IE11, it doesn't seem to be able to display the image with just a blank region. Didn't find any information on IE11 support or polyfill as this is quite new, assume this is a degradation?

Steps to reproduce

https://github.com/hazuremon/gatsby-bug-repro/
https://eager-saha-ba67b0.netlify.app/ (Open in IE11 will see a blank screen, while seeing an image in all other browsers)

Expected result

What should happen?
Display image

Actual result

Briefly shows the lazyload placeholder image before seeing a blank region.

Environment

IE11

Run gatsby info --clipboard in your project directory and paste the output here.

@hazuremon hazuremon added the type: bug An issue or pull request relating to a bug in Gatsby label Mar 6, 2021
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 6, 2021
@egemenu
Copy link

egemenu commented Mar 6, 2021

Actually object-fit polyfill is working but not in the right way.

Looking forward to any solution here 👀

@LekoArts LekoArts added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 8, 2021
@LekoArts
Copy link
Contributor

LekoArts commented Mar 8, 2021

Actually object-fit polyfill is working but not in the right way.

What do you mean by that @egemenu ?

@hazuremon
Copy link
Author

Actually object-fit polyfill is working but not in the right way.

What do you mean by that @egemenu ?

I think polyfill is working as well, as the image gets briefly displayed before it disappeared. I am not sure but I suspect it's the lazyload placeholder layer is not swapped out which prevent the image from displaying?

@safesitefacilitiesdev
Copy link

If anyone needs a quick and dirty solution to this, I noticed removing 'position: relative' from the picture element displays the images in ie11. Doing this with CSS globally, targeting the class the polyfill adds is fairly trivial:

.object-fit-polyfill[style] { position:static !important; }

@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Apr 17, 2021
@egemenu
Copy link

egemenu commented May 3, 2021

If anyone needs a quick and dirty solution to this, I noticed removing 'position: relative' from the picture element displays the images in ie11. Doing this with CSS globally, targeting the class the polyfill adds is fairly trivial:

.object-fit-polyfill[style] { position:static !important; }

This didn't work actually. I guess cause I work with with modular css. So instead of adding like that, I've added it to head of html

<style type="text/css">{`
    picture.object-fit-polyfill {
    position: static!important;
  }
`}</style>

But you're right, this is definitely a dirty solution. Still watching for any proper fix.

@github-actions github-actions bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label May 4, 2021
@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label May 24, 2021
@timmywil
Copy link

timmywil commented May 24, 2021

Just to make this unstale, the workaround works, but this should probably be changed in gatsby. It affects <StaticImage> in IE as well.

@github-actions github-actions bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label May 25, 2021
@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jun 14, 2021
@timmywil
Copy link

This is still an issue. While it has to do with the object-fit polyfill, it may have more to do with gatsby's use of the polyfill. Currently, no <GatsbyImage> or <StaticImage> displays in IE. I'm sure the maintainers are busy, tho, so I will see if I can make a PR.

@github-actions github-actions bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label Jun 15, 2021
@github-actions
Copy link

github-actions bot commented Jul 5, 2021

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jul 5, 2021
@wardpeet wardpeet self-assigned this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more. topic: media Related to gatsby-plugin-image, or general image/media processing topics type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants