Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-contentful): Set image source format #30103

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Mar 8, 2021

When generating image data, use the source image format coming from Contentful, rather than making the plugin helper infer it from the file extention. Fixes #30069

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 8, 2021
@ascorbic ascorbic added topic: source-contentful Related to Gatsby's integration with Contentful and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 8, 2021
Copy link
Collaborator

@axe312ger axe312ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascorbic ascorbic merged commit 759ed72 into master Mar 8, 2021
@ascorbic ascorbic deleted the fix/contentful-image-ext branch March 8, 2021 16:10
@xmflsct
Copy link

xmflsct commented Mar 8, 2021

Thank you @ascorbic !

vladar pushed a commit that referenced this pull request Mar 9, 2021
vladar pushed a commit that referenced this pull request Mar 9, 2021
(cherry picked from commit 759ed72)

Co-authored-by: Matt Kane <matt@gatsbyjs.com>
@vladar
Copy link
Contributor

vladar commented Mar 9, 2021

Published in gatsby-source-contentful@5.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gatsby-source-contentful] Image file extension in capital letters
4 participants