-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-plugin-google-tagmanager): add option for selfHostedOrigin #32733
Conversation
@wardpeet Can you help determine why the tests aren't passing? I can't decipher any reasons why this is being stopped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests as well? You also have to make it a little bit more robust so origin never ends with a /.
You can skip pnp test for now.
@wardpeet thanks for the notes. Tests added, and change changed. |
hey there @wardpeet - Im curious about the process from here- I'd like to get this feature in use as a plugin if we can. Anything else I can do to push this forward? |
Hey @tackaberry, sorry this was forgotten on my end. I've updated the branch with latest master and will go over it one last time and merge. |
Great. Thanks for merging in master. Anything I have to do at this point? How long typically until it gets merged in and available in the release? |
@tackaberry normally only a day when things are good to go. We publish it under the |
gatsbyjs#32733) In the gatsby-plugin-google-tagmanager, this change supports variable selfHostedOrigin, defaulting to googletagmanager.com. With the advent of Server Side Tagging, we have the ability to serve gtm.js from "self-hosted" tagging server. See: developers.google.com/tag-manager/serverside And: developers.google.com/tag-manager/serverside/send-data#update_the_gtmjs_source_domain Co-authored-by: Ward Peeters <ward@coding-tech.com>
Description
In the
gatsby-plugin-google-tagmanager
, this change supports variable selfHostedOrigin, defaulting to googletagmanager.com.With the advent of Server Side Tagging, we have the ability to serve gtm.js from "self-hosted" tagging server.
See: https://developers.google.com/tag-manager/serverside
And: https://developers.google.com/tag-manager/serverside/send-data#update_the_gtmjs_source_domain
Thus the base url, instead of googletagmanager.com could be sst.example.com or analytics.example.com.
Follow up to discussion: #32719
With
selfHostedOrigin: 'https://sst.example.com'
:Default:
Documentation
There is a related change to the README in the package.