Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade some non-breaking major versions #37406

Merged
merged 23 commits into from
Jan 9, 2023
Merged

chore: Upgrade some non-breaking major versions #37406

merged 23 commits into from
Jan 9, 2023

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Jan 5, 2023 •
edited
Loading

Description

I've looked at #30477 and #16840 and taken some dependencies from there to manually update them.

List of Changes

Documentation

Related Issues

[ch59901]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 5, 2023
@LekoArts LekoArts added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 5, 2023
@LekoArts
Copy link
Contributor Author

LekoArts commented Jan 5, 2023 •
edited
Loading

Had to remove the upgrade of jscodeshift and recast because of benjamn/recast#1248

@LekoArts
Revert "glob"
7f42e8e 
This reverts commit d5341cb.
@LekoArts
Copy link
Contributor Author

LekoArts commented Jan 5, 2023

Reverted upgrade of glob as one test showed (on windows) that we were passing the file paths into glob without converting backslashes to forwardslashes. So this feels a bit too dangerous to just ship it, let's make sure in a separate PR that all inputs to glob use forwardslashes

@LekoArts LekoArts marked this pull request as ready for review January 6, 2023 08:44
@LekoArts
Copy link
Contributor Author

LekoArts commented Jan 9, 2023

Partytown was updated in separate PR: #37421

pieh
pieh previously approved these changes Jan 9, 2023
View reviewed changes
@pieh pieh merged commit 2ea80c0 into master Jan 9, 2023
@pieh pieh deleted the upgrade-non-breaking-majors branch January 9, 2023 14:50
mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
@LekoArts @hoobdeebla
chore: Upgrade some non-breaking major versions (gatsbyjs#37406)
50087ea 
* cpy-cli

* boxen

* fs-extra

Co-authored-by: Adam Schay <adamschay@gmail.com>

* jscodeshift

* recast

* webpack-virtual-modules

* mime

* babel-plugin-macros

* debug

* partytown

* cookie

* misc

* glob

* camelcase

* js-yaml

* trigger ci

* fix cpy commands

* revert codemods change

* Revert "glob"

This reverts commit d5341cb.

* update more fs-extra

Co-authored-by: Adam Schay <adamschay@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LekoArts @pieh