-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gatsby's documentation about visual testing with storybook is out of date / not working. #37936
Comments
Hi, thanks for the issue! I don't personally use Storybook and we probably also won't spend any time writing glue code for this. I assume you refer to the 7.0 release? If I read it correctly, they introduced a new API: https://storybook.js.org/blog/framework-api/ It seems like https://storybook.js.org/docs/react/contribute/framework needs to be followed for Gatsby now. But again, we don't have time to do this, so it's up for the community to contribute this. However, I've seen storybookjs/storybook#22065, so happy to help updating our docs. |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. Thanks for being a part of the Gatsby community! 💪💜 |
Still an issue |
Hey! Is this issue still open? |
Looks like storybook's own Gatsby example is broken on their v7 version, so they need to provide guidance on what should change. There is already an open issue on the Storybook repo. Since the issue was introduced by them, it will be tracked there. I guess this can remain open to update docs once the underlying functionality is fixed. |
will be better if a Video tutorial is made. |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. Thanks for being a part of the Gatsby community! 💪💜 |
Still an issue |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. Thanks for being a part of the Gatsby community! 💪💜 |
can someone assign me this issue? would love to work on it! |
I have already asked for it. Let's see |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. Thanks for being a part of the Gatsby community! 💪💜 |
Hi I can work on the issue if its still open |
Lets work on this |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. Thanks for being a part of the Gatsby community! 💪💜 |
Still an issue |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. Thanks for being a part of the Gatsby community! 💪💜 |
Issue? |
Is this still an issue? |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. Thanks for being a part of the Gatsby community! 💪💜 |
Still an issue for me: I'm not able to update from the storybook 6.5 version, which consequentially (for particular conditions) blocks me from updating typescript from the 4.7 version |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. Thanks for being a part of the Gatsby community! 💪💜 |
still an issue |
can I work on this issue ? |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here. Thanks for being a part of the Gatsby community! 💪💜 |
Hey again! It’s been 60 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it. Thanks again for being part of the Gatsby community! 💪💜 |
Preliminary Checks
Summary
Storybook has had an update and the documentation linked to configuring storybook no longer works!
Also Gatsby's Link component doesnt play nice with storybook any longer. This is how i came across the issue with this part of the documentation.
Im not sure exactly on how to resolve these issues, but thought it would be worth reporting incase other people have any issues setting it up in the mean time!
Steps to Resolve this Issue
npm run storybook
to start storybook and see the errors with Gatsby Link.main.js
and thepreview.js
into the respective files and runnpm run storybook
and see further errors.The text was updated successfully, but these errors were encountered: