Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatsby's documentation about visual testing with storybook is out of date / not working. #37936

Closed
2 tasks done
darylthornhill opened this issue Apr 12, 2023 · 26 comments
Closed
2 tasks done
Labels
good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with. stale? Issue that may be closed soon due to the original author not responding any more. type: documentation An issue or pull request for improving or updating Gatsby's documentation

Comments

@darylthornhill
Copy link

Preliminary Checks

Summary

Storybook has had an update and the documentation linked to configuring storybook no longer works!

Also Gatsby's Link component doesnt play nice with storybook any longer. This is how i came across the issue with this part of the documentation.

Im not sure exactly on how to resolve these issues, but thought it would be worth reporting incase other people have any issues setting it up in the mean time!

Steps to Resolve this Issue

  1. download https://github.com/darylthornhill/test-gatsby-storybook-error npm run storybook to start storybook and see the errors with Gatsby Link.
  2. After trying that, copy and paste the example code pieces for the main.js and the preview.js into the respective files and run npm run storybook and see further errors.
@darylthornhill darylthornhill added the type: documentation An issue or pull request for improving or updating Gatsby's documentation label Apr 12, 2023
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 12, 2023
@LekoArts LekoArts added help wanted Issue with a clear description that the community can help with. good first issue Issue that doesn't require previous experience with Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 13, 2023
@LekoArts
Copy link
Contributor

Hi, thanks for the issue!

I don't personally use Storybook and we probably also won't spend any time writing glue code for this. I assume you refer to the 7.0 release?
https://storybook.js.org/releases/7.0

If I read it correctly, they introduced a new API: https://storybook.js.org/blog/framework-api/
But I couldn't find anything for Gatsby.

It seems like https://storybook.js.org/docs/react/contribute/framework needs to be followed for Gatsby now. But again, we don't have time to do this, so it's up for the community to contribute this.

However, I've seen storybookjs/storybook#22065, so happy to help updating our docs.

@github-actions
Copy link

github-actions bot commented May 3, 2023

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label May 3, 2023
@rasmusbe
Copy link

rasmusbe commented May 3, 2023

Still an issue

@github-actions github-actions bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label May 4, 2023
@Vishrut19
Copy link

Hey! Is this issue still open?

@graysonhicks
Copy link
Contributor

Looks like storybook's own Gatsby example is broken on their v7 version, so they need to provide guidance on what should change. There is already an open issue on the Storybook repo. Since the issue was introduced by them, it will be tracked there. I guess this can remain open to update docs once the underlying functionality is fixed.

storybookjs/storybook#21958

@hameemkay
Copy link

will be better if a Video tutorial is made.

@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jun 18, 2023
@rasmusbe
Copy link

Still an issue

@github-actions github-actions bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label Jun 19, 2023
@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jul 10, 2023
@ranjanmangla1
Copy link

can someone assign me this issue? would love to work on it!

@Vishrut19
Copy link

I have already asked for it. Let's see

@github-actions github-actions bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label Jul 11, 2023
@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jul 31, 2023
@quantumflo
Copy link

Hi I can work on the issue if its still open

@github-actions github-actions bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label Aug 25, 2023
@VineeTagarwaL-code
Copy link

Lets work on this

@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Sep 30, 2023
@pb-saloni-sahu
Copy link

Still an issue

@github-actions github-actions bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label Oct 5, 2023
@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Oct 25, 2023
@apneduniya
Copy link

Issue?

@github-actions github-actions bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label Nov 7, 2023
@TheShiveshNetwork
Copy link

Is this still an issue?

Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Dec 14, 2023
@bwlt
Copy link

bwlt commented Dec 14, 2023

Still an issue for me: I'm not able to update from the storybook 6.5 version, which consequentially (for particular conditions) blocks me from updating typescript from the 4.7 version

@github-actions github-actions bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label Dec 14, 2023
Copy link

github-actions bot commented Jan 4, 2024

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jan 4, 2024
@jdahdah
Copy link
Contributor

jdahdah commented Feb 6, 2024

still an issue

@github-actions github-actions bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 7, 2024
@yacxn
Copy link

yacxn commented Feb 7, 2024

can I work on this issue ?

Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 27, 2024
Copy link

github-actions bot commented Apr 7, 2024

Hey again!

It’s been 60 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.
Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to comment on this issue or create a new one if you need anything else.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community! 💪💜

@github-actions github-actions bot closed this as completed Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue that doesn't require previous experience with Gatsby help wanted Issue with a clear description that the community can help with. stale? Issue that may be closed soon due to the original author not responding any more. type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

No branches or pull requests