Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"node_modules\gatsby-plugin-offline\app-shell.js" didn't pass validation #3939

Closed
mpolinowski opened this issue Feb 9, 2018 · 2 comments
Closed
Assignees
Labels
type: bug An issue or pull request relating to a bug in Gatsby

Comments

@mpolinowski
Copy link

Description

Saw this issue with my repo and reproduced it with gatsbyjs.org source.

After update gatsby/gatsby-cli to latest gatsby build fails.

Environment

Gatsby CLI version: 1.1.39
Node.js version: v9.5.0
Operating System: Windows 10

File contents (if changed):

gatsby-config.js: not changed
package.json:

{
  "name": "gatsby-starter-default",
  "description": "Gatsby default starter",
  "version": "1.0.0",
  "author": "Kyle Mathews <mathews.kyle@gmail.com>",
  "dependencies": {
    "bluebird": "^3.5.1",
    "gatsby": "^1.9.188",
    "gatsby-image": "^1.0.35",
    "gatsby-link": "^1.6.36",
    "gatsby-plugin-canonical-urls": "^1.0.12",
    "gatsby-plugin-catch-links": "^1.0.15",
    "gatsby-plugin-feed": "^1.3.10",
    "gatsby-plugin-glamor": "^1.6.11",
    "gatsby-plugin-google-analytics": "^1.0.17",
    "gatsby-plugin-lodash": "^1.0.8",
    "gatsby-plugin-manifest": "^1.0.13",
    "gatsby-plugin-netlify": "^1.0.0",
    "gatsby-plugin-nprogress": "^1.0.11",
    "gatsby-plugin-offline": "^1.0.13",
    "gatsby-plugin-react-helmet": "^2.0.4",
    "gatsby-plugin-react-next": "^1.0.8",
    "gatsby-plugin-sharp": "^1.6.27",
    "gatsby-plugin-sitemap": "^1.2.12",
    "gatsby-plugin-twitter": "^1.0.10",
    "gatsby-plugin-typography": "^1.7.13",
    "gatsby-remark-autolink-headers": "^1.4.11",
    "gatsby-remark-copy-linked-files": "^1.5.26",
    "gatsby-remark-images": "^1.5.43",
    "gatsby-remark-prismjs": "^1.2.8",
    "gatsby-remark-responsive-iframe": "^1.4.16",
    "gatsby-remark-smartypants": "^1.4.7",
    "gatsby-source-filesystem": "^1.5.18",
    "gatsby-transformer-csv": "^1.3.5",
    "gatsby-transformer-documentationjs": "^1.4.6",
    "gatsby-transformer-remark": "^1.7.31",
    "gatsby-transformer-sharp": "^1.6.18",
    "gatsby-transformer-yaml": "^1.5.14",
    "graphql-request": "^1.4.1",
    "gray-percentage": "^2.0.0",
    "limax": "^1.6.0",
    "lodash": "^4.16.6",
    "mitt": "^1.1.3",
    "parse-filepath": "^1.0.2",
    "react-helmet": "^5.2.0",
    "react-icons": "^2.2.7",
    "slash": "^1.0.0",
    "typeface-space-mono": "^0.0.40",
    "typeface-spectral": "^0.0.40",
    "typography-breakpoint-constants": "^0.15.10",
    "typography-plugin-code": "^0.16.11"
  },
}

gatsby-node.js: not changed
gatsby-browser.js: not changed
gatsby-ssr.js: not changed

Actual result

E:\gatsby\www>gatsby build
success delete html files from previous builds — 0.055 s
success open and validate gatsby-config.js — 0.004 s
success copy gatsby files — 0.092 s
success onPreBootstrap — 0.007 s
success source and transform nodes — 0.888 s
success building schema — 0.867 s
success createLayouts — 0.012 s
⠁

The page component at "node_modules\gatsby-plugin-offline\app-shell.js" didn't pass validation

The page component must export a React component for it to be valid

Steps to reproduce

1. clone repo gatsbyjs.org source

2. npm install / npm update

3. gatsby build

@pieh
Copy link
Contributor

pieh commented Feb 9, 2018

Downgrading gatsby to 1.9.186 should allow you to build gatsby. Will investigate how to properly fix that

@mpolinowski
Copy link
Author

rolled back to gatsby-cli@1.1.39 / gatsby@1.9.184 - it works

@ghost ghost assigned pieh Feb 9, 2018
@ghost ghost added the review label Feb 9, 2018
@pieh pieh added the type: bug An issue or pull request relating to a bug in Gatsby label Feb 9, 2018
@ghost ghost removed the review label Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

No branches or pull requests

2 participants