Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1][gatsby-plugin-catch-links] workaround for ie a.pathname bug #8685

Merged
merged 2 commits into from
Oct 5, 2018
Merged

[v1][gatsby-plugin-catch-links] workaround for ie a.pathname bug #8685

merged 2 commits into from
Oct 5, 2018

Conversation

ahinrichs
Copy link
Contributor

@ahinrichs ahinrichs commented Oct 1, 2018 •
edited
Loading

Plugin was broken in IE before PR #7779 and still is. See PR #8494 for details. This is the same fix I suggested in PR #8646 v2 port of this

@ahinrichs ahinrichs mentioned this pull request Oct 1, 2018
Merged
jdfm
jdfm approved these changes Oct 4, 2018
View reviewed changes
Copy link

@jdfm jdfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdfm
Copy link

jdfm commented Oct 4, 2018

I wasn't even aware that this was an issue when I pushed my fix a while back. Nice catch!

pieh
pieh approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahinrichs

@pieh pieh merged commit 9801542 into gatsbyjs:v1 Oct 5, 2018
@gatsbot
Copy link

gatsbot bot commented Oct 5, 2018

Holy buckets, @ahinrichs — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@pieh
Copy link
Contributor

pieh commented Oct 5, 2018

Published as gatsby-plugin-catch-links@1.0.26

pieh pushed a commit that referenced this pull request Oct 5, 2018
@rscott @pieh
fix: handle more edge cases and fix IE (#8646)
4383a57 
* Port v1 updates of gatsby-plugin-catch-links to v2

* [gatsby-plugin-catch-links] workaround for ie a.pathname bug (#8685)

* workaround for ie a.pathname bug

* better english

* format

* remove console.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

@jdfm jdfm jdfm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahinrichs @jdfm @pieh