Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gatsby version to latest to solve issue 9145 #9150

Merged
merged 2 commits into from
Oct 16, 2018

Conversation

GuyKh
Copy link
Contributor

@GuyKh GuyKh commented Oct 16, 2018

Update Gatsby version to latest to solve issue #9145

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all - thanks for proactive approach here. Just minor change needed to more precisely define version range

@@ -28,7 +28,7 @@
"license": "MIT",
"main": "index.js",
"peerDependencies": {
"gatsby": ">2.0.0-beta"
"gatsby": ">=2.0.24"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be 2.0.20 (that's where this API was added)

@GuyKh
Copy link
Contributor Author

GuyKh commented Oct 16, 2018

@pieh - ready :)

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GuyKh!

@pieh pieh merged commit f5c5556 into gatsbyjs:master Oct 16, 2018
@gatsbot
Copy link

gatsbot bot commented Oct 16, 2018

Holy buckets, @GuyKh — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@GuyKh GuyKh deleted the issue9145 branch October 16, 2018 14:02
jedrichards pushed a commit to jedrichards/gatsby that referenced this pull request Nov 1, 2018
* Update Gatsby version to latest to solve issue 9145

* Update package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants