Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traced SVG for gatsby-remark-images #9414

Closed
hackhat opened this issue Oct 26, 2018 · 5 comments
Closed

Traced SVG for gatsby-remark-images #9414

hackhat opened this issue Oct 26, 2018 · 5 comments
Labels
help wanted Issue with a clear description that the community can help with. stale? Issue that may be closed soon due to the original author not responding any more.

Comments

@hackhat
Copy link

hackhat commented Oct 26, 2018

Reopen #4624

I am using Traced SVG option from gatsby-image for my non-article images and I love it.

However for my markdown images, there is only available blur-up effect, which means image loading is inconsistent. It would be nice to have traced svg also for gatsby-remark-ima

@kakadiadarpan
Copy link
Contributor

@hackhat would you be open to work on this and raise a PR?

You can get the required information from #4624, if you need more support we can help you.

@kakadiadarpan kakadiadarpan added the help wanted Issue with a clear description that the community can help with. label Oct 26, 2018
@hackhat
Copy link
Author

hackhat commented Oct 26, 2018

@kakadiadarpan I can't do it at the moment, sorry. I took a look at the code and is a huge function that does everything (for the image), anyone is considering to refactor that in something more digestable?

@tlent
Copy link
Contributor

tlent commented Oct 27, 2018

I have started working on this and made some good progress. I will be opening a pull request soon.

@gatsbot
Copy link

gatsbot bot commented Jan 26, 2019

Old issues will be closed after 30 days of inactivity. This issue has been quiet for 20 days and is being marked as stale. Reply here or add the label "not stale" to keep this issue open!

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jan 26, 2019
@gatsbot
Copy link

gatsbot bot commented Feb 6, 2019

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

Thanks again for being part of the Gatsby community!

@gatsbot gatsbot bot closed this as completed Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issue with a clear description that the community can help with. stale? Issue that may be closed soon due to the original author not responding any more.
Projects
None yet
Development

No branches or pull requests

4 participants