Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-offline): Sync docs with actual defaults being used #9903

Merged

Conversation

ubergesundheit
Copy link
Contributor

I've noticed the Readme of gatsby-plugin-offline is out of sync with the actual defaults from its gatsby-node.js.

This commit fixes this by copying the options object from gatsby/packages/gatsby-plugin-offline/src/gatsby-node.js into this Readme.

I've noticed the Readme of gatsby-plugin-offline is out of sync with the actual defaults from its gatsby-node.js.

This commit fixes this by copying the options object from gatsby/packages/gatsby-plugin-offline/src/gatsby-node.js into this Readme.
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 Thanks @ubergesundheit!

@pieh pieh changed the title Fix gatsby-plugin-offline defaults in Readme fix(gatsby-plugin-offline): Sync docs with actual defaults being used Nov 13, 2018
@pieh pieh merged commit 8cd7432 into gatsbyjs:master Nov 13, 2018
@gatsbot
Copy link

gatsbot bot commented Nov 13, 2018

Holy buckets, @ubergesundheit — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
…gatsbyjs#9903)

I've noticed the Readme of gatsby-plugin-offline is out of sync with the actual defaults from its gatsby-node.js.

This commit fixes this by copying the options object from gatsby/packages/gatsby-plugin-offline/src/gatsby-node.js into this Readme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants