Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] How to manage suggestions section on the How to Open Pull Requests guide #18745

Merged
merged 12 commits into from
Oct 29, 2019
Merged

[docs] How to manage suggestions section on the How to Open Pull Requests guide #18745

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bfd37fc
resolves #14598
Sep 21, 2019
f6d376e
Fixed typos and added related content
Sep 21, 2019
5f6066c
Fixed additional typos
Sep 21, 2019
e90b62b
Fixed additional typos, one with the name of the file, added links fo…
urielhdz Sep 23, 2019
18bb470
Updated title based on @marcysutton suggestions
Sep 24, 2019
552e796
Solves suggested changes such as modifying links for relative urls, r…
urielhdz Sep 24, 2019
2db5d7f
Merge branch 'master' of https://github.com/urielhdz/gatsby
urielhdz Sep 24, 2019
91e686a
Apply additional suggestions
Sep 25, 2019
c0b0231
Merge branch 'master' of https://github.com/gatsbyjs/gatsby
urielhdz Oct 4, 2019
2a5c507
Added a section on how to handle reviews on your PR
urielhdz Oct 16, 2019
df15d81
Apply suggestions from code review
urielhdz Oct 22, 2019
3ec8aac
Merge remote-tracking branch 'upstream/master' into reviews-section-o…
Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions docs/contributing/how-to-open-a-pull-request.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,25 @@ There are specific pages about contributing to various parts of the Gatsby ecosy

For the Gatsby blog, it's necessary to run your content idea by the Gatsby team before submitting it. For more information, refer to the page on [blog and website contributions](/contributing/blog-and-website-contributions/), including how to propose an idea and setting up the blog to run locally.

## Follow up with reviews and suggestions

After a PR is sent to the Gatsby GitHub repo, the Gatsby core team and the community may suggest modifications to the changes that your PR introduces.

The Gatsby core and learning teams review and approve every PR that the community sends to make sure that it meets the contribution guidelines of the repo, and to find opportunities for improvement to your PR changes.

These suggestions may also be called "request changes" by the GitHub UI. When a change request is added to your PR, this and the rest of the change requests will appear on the GitHub page for your PR. From this page you can use the suggestions UI to:

- Review the suggested changes using the "View changes" button.
- [Commit](https://help.github.com/en/articles/incorporating-feedback-in-your-pull-request#applying-suggested-changes) the suggestions.
- [Discuss suggestions](https://help.github.com/en/articles/about-conversations-on-github) to ask questions about the suggested changes.
- [Add suggestions to a batch](https://help.github.com/en/articles/incorporating-feedback-in-your-pull-request#applying-suggested-changes) so they can be pushed in a single commit.

For suggestions that may not be resolved using the GitHub UI, remember that you can keep adding related commits to your PR before it is merged and those commits will also be a part of such PR.

After all your questions have been resolved and the requested changes have been committed, you can [mark the conversation as solved](https://help.github.com/en/articles/commenting-on-a-pull-request#resolving-conversations).

This process helps both the Gatsby team and the community to contribute with improvements for your changes before they are merged into the Gatsby GitHub repo.

## Update your fork with the latest Gatsby changes

The Gatsby GitHub repo is very active, so it's likely you'll need to update your fork with the latest changes to be able to merge in your code. This requires adding Gatsby as an [upstream remote](https://help.github.com/en/articles/configuring-a-remote-for-a-fork):
Expand Down