enhancement (docs, www): MDX component alias #23209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
reviewed
Apr 17, 2020
# Conflicts: # docs/contributing/docs-and-blog-components.md # www/src/gatsby-plugin-theme-ui/components.js
# Conflicts: # docs/contributing/docs-and-blog-components.md # www/src/gatsby-plugin-theme-ui/components.js
gillkyle
previously approved these changes
Apr 24, 2020
There was a problem hiding this comment.
I think if this helps unblock internationalization then it's worth getting merged in. The questions on level of granularity and discouraging it from being used seem like they could be answered in the future too (if they become problems) 🤷
I'm not sure personally what issues could be run into doing this, but if it's working for Docusaurus and might work for us I say great!
# Conflicts: # www/package.json
AishaBlake
suggested changes
Apr 29, 2020
| @@ -156,77 +156,24 @@ Rendered, the component looks like this: | |||
| Connect your Gatsby site to Storage Provider for automatic deployments | |||
| </CloudCallout> | |||
|
|
|||
There was a problem hiding this comment.
The ComponentModel was recently made more flexible, so I think it's worth keeping the documentation for it since we'll be able to use it in more places.
AishaBlake
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
gatsby-alias-imports@componentalias pointing towww/src/componentswww/gatsby-plugin-theme-ui/componentsand instead import them using the new aliascontributing/docs-and-blog-components.Motivation
See: #20795 (comment)
Open Questions
@site/@wwwalias instead?www?Related Issues
fixes: #20795
partially fixes: #21470