chore(*): Use new createContentDigest helper #8992
Conversation
There was a problem hiding this comment.
This looks good! I've seen a few PRs now where createContentDigest is mocked in tests, which is technically fine but I think we'd prefer if the real implementation was made available to nodes so snapshots track any regressions there.
Sound like work you're interested in fixing up?
|
Yes I can definitely work on re-implementing tests to use For clarification, this would mean that the snapshots, instead of having Thanks! |
|
@samscha that is exactly right! |
gatsby-source-hacker-news gatsby-source-lever gatsby-source-mongodb gatsby-transformer-excel
| const { resolve, parse } = require(`path`) | ||
|
|
||
| const axios = require(`axios`) | ||
| const { pathExists, createWriteStream } = require(`fs-extra`) | ||
|
|
||
| const createContentDigest = require(`../../gatsby/src/utils/create-content-digest`) |
There was a problem hiding this comment.
we should pass this from caller and not import directly here
There was a problem hiding this comment.
we should only import it directly for tests
There was a problem hiding this comment.
thank you for the comment! getting from the caller makes a lot more sense! I fixed all but two of these instances in previous commits.
I'm going to work on removing the import from gatsby-source-contentful and gatsby-transformer-sqip (both use the cache-image code mentioned above)
remove direct import
…s/createContentDigest-plugins
wardpeet
changed the title
wardpeet
added
the
bot: merge on green
|
Holy buckets, @samscha — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
|
Thanks! |
This reverts commit c91d110.
|
Hey @samscha! We unfortunately had to revert this — looks like there were a couple of problems that we didn't catch before merging. Could you put up a new PR with these fixes? Basically we need to keep the old implementations around as a fallback as many people won't upgrade For the fallbacks, perhaps move them to a separate file e.g. |
|
Got it. Will open up a new PR! Where exactly would the |
|
Thanks! The |
* add createContentDigest helper for gatsby-transformer-remark * add createContentDigest helper for gatsby-source-filesystem * Added createContentDigest in test * Added missing createContentDigest param * update createContentDigest helper tests for gatsby-transformer-remark * update createContentDigest helper tests for gatsby-source-filesystem * update createContentDigest helper tests for gatsby-transformer-csv * add createContentDigest helper for internal-plugins/internal-data-bridge * add createContentDigest helper for gatsby-source-hacker-news * add createContentDigest helper for gatsby-transformer-excel * add createContentDigest helper for gatsby-source-mongodb * add createContentDigest helper for gatsby-source-lever * add createContentDigest helper for internal-plugins/query-runner * Updated gatsby dep gatsby-source-hacker-news gatsby-source-lever gatsby-source-mongodb gatsby-transformer-excel * add createContentDigest helper for gatsby-source-contentful * add createContentDigest helper for gatsby-transformer-hjson * add createContentDigest helper for gatsby-transformer-sqip * add createContentDigest helper for gatsby-source-npm-package-search * add createContentDigest helper for gatsby-transformer-toml * update createContentDigest helper for gatsby-source-mongodb remove direct import * update createContentDigest helper for gatsby-source-lever could not find import for createGraphQLNode, added helper anyways * update createContentDigest helper for internal-plugins/query-runner modify src/bootstrap (imports writeRedirects) * update createContentDigest helper for gatsby-source-npm-package-search * update createContentDigest helper for gatsby-source-contentful* TODO add ccd (createContentDigest) in cache-image * update createContentDigest helper for gatsby-transformer-sqip* TODO add ccd (createContentDigest) in generate-sqip * update createContentDigest helper for gatsby-transformer-sqip removed ccd from tests * use caret version selector * no need to import it - it's passed to `sourceNodes` * merge again * update to pass tests * update hash to use createContentDigest * move createContentDigest to import * move createContentDigest to import for gatsby-source-contentful * remove createContentDigest import in gatsby-source-filesystem test * rereplace createContentDigest with crypto in gatsby-source-filesystem * revert createContentDigest to crypto for create-file-node in gatsby-source-filesystem * revert createContentDigest for gatsby-plugin-sharp * update crypto misspell * revert gatsby-remark-contentful and gatsby-source-contentful * fix old code * fix old code v2 * update gatsby pkg * revert gatsby-transformer-remark * add export for gatsby utils * update gatsby-source-filesystem * revert gatsby-source-graphql * revert gatsby-source-graphql * revert gatsby-source-hacker-news * revert gatsby-source-lever * revert gatsby-source-medium * revert gatsby-source-mongodb * revert gatsby-source-mongodb mapping * revert gatsby-source-npm-package-search * revert gatsby-source-wikipedia * revert gatsby-source-wordpress * revert gatsby-transformer-csv * revert gatsby-transformer-documentationjs * revert gatsby-transformer-excel * revert gatsby-transformer-hjson * revert other packages * revert some pkgs * add gatsby * move gatsby to peerdeps
Note: this is my first pr to Gatsby so if I'm missing something (best practices included), please do tell me about them and I'll update this/future pr's.
Added createContentDigest helper for gatsby-transformer-remark and gatsby-source-filesystem.
I opened this pr right now mainly because I wanted to make sure I was adding the createContentDigest helper to these two plugins correctly and not breaking anything (before going on to other plugins).
If it's more convenient, and I have verification I correctly added the createContentDigest helper to these two plugins, this pr can be closed and I can open a new pr later with more plugins that have the createContentDigest helper added.
Thanks!
from
#8805