Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colorized output on windows #29

Merged
merged 5 commits into from
Jan 16, 2017
Merged

Colorized output on windows #29

merged 5 commits into from
Jan 16, 2017

Conversation

elliott-beach
Copy link
Contributor

Add support for windows, with slight color change. Bold and underline effects will be silently suppressed on windows. Tested on WINE.

Other changes:

  • remove tab indentation in fixCodePage() function
  • delete supportsColor() function, as I assume that we have all required platforms covered
  • add colorama to the list of dependencies
  • In fixCodePage, I got an AttributeError while testing, and added a dummy except block if changing the font is not supported.

@gautamkrishnar gautamkrishnar merged commit 3eca8ef into gautamkrishnar:master Jan 16, 2017
@gautamkrishnar
Copy link
Owner

Thanks a lot @e-beach 😄 It's looking awesome...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gautamkrishnar gautamkrishnar gautamkrishnar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliott-beach @gautamkrishnar