You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The set of system headers -- include-able Karel files that are provided as part of the FRVC packages -- is currently hard-coded in ktransw.py in is_system_header(..) (here).
In reality not all FRVC packages provide the same set of files, which could cause problems when a 'back-ported' header is used and which is then incorrectly considered to be a system header.
This should be fixed. Possible approaches are maintaining per-version lists in ktransw.py, or having ktransw check whether a header is really a system header by checking the version specific sub dir of WinOLPC (or wherever ktrans.exe and friends are located).
The latter is expensive, but as is_system_header(..) is only used when generating dependency files, the overhead is probably acceptable.
The text was updated successfully, but these errors were encountered:
The set of system headers -- include-able Karel files that are provided as part of the FRVC packages -- is currently hard-coded in
ktransw.py
inis_system_header(..)
(here).In reality not all FRVC packages provide the same set of files, which could cause problems when a 'back-ported' header is used and which is then incorrectly considered to be a system header.
This should be fixed. Possible approaches are maintaining per-version lists in
ktransw.py
, or havingktransw
check whether a header is really a system header by checking the version specific sub dir ofWinOLPC
(or whereverktrans.exe
and friends are located).The latter is expensive, but as
is_system_header(..)
is only used when generating dependency files, the overhead is probably acceptable.The text was updated successfully, but these errors were encountered: