Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set of 'system headers' should be determined by system runtime version #8

Open
gavanderhoorn opened this issue Apr 29, 2016 · 0 comments

Comments

@gavanderhoorn
Copy link
Owner

gavanderhoorn commented Apr 29, 2016

The set of system headers -- include-able Karel files that are provided as part of the FRVC packages -- is currently hard-coded in ktransw.py in is_system_header(..) (here).

In reality not all FRVC packages provide the same set of files, which could cause problems when a 'back-ported' header is used and which is then incorrectly considered to be a system header.

This should be fixed. Possible approaches are maintaining per-version lists in ktransw.py, or having ktransw check whether a header is really a system header by checking the version specific sub dir of WinOLPC (or wherever ktrans.exe and friends are located).

The latter is expensive, but as is_system_header(..) is only used when generating dependency files, the overhead is probably acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant