Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry coordinates should be numbers and not strings #1

Open
cridmann opened this issue May 27, 2014 · 3 comments
Open

Geometry coordinates should be numbers and not strings #1

cridmann opened this issue May 27, 2014 · 3 comments

Comments

@cridmann
Copy link
Contributor

Hey Gavin - thanks for putting this data together...used it for a little demo.

As I am implementing in scala (using https://github.com/jroper/play-geojson), I ran into a few type safety issues.

Specifically:

"geometry": {
"type": "Point",
"coordinates": [
"-80.140924",
"25.789141"
]
}

Should be
"geometry": {
"type": "Point",
"coordinates": [
-80.140924,
25.789141
]
}

I wrote a little node script that fixes this - if you want me to pull request the converted data, let me know.

@gavinr
Copy link
Owner

gavinr commented May 27, 2014

Hi Chris! Yeah please submit the PR for sure!

I used one of my other projects, https://github.com/gavreh/csv-to-geojson as one of the steps to generate this data set, which did in fact have this problem that you're mentioning (gavinr/csv-to-geojson#1), and it's now fixed in that project. It'll be great to get this repo's data into the proper format.

Thanks!

cridmann referenced this issue in cridmann/usa-mcdonalds-locations May 29, 2014
@cridmann
Copy link
Contributor Author

Aha! yes, devil in the details...

hopefully the PR went through,
cheers

@phelpsar3
Copy link

Hey Gavin,

I am having a hell of a time to parse that geojson of McDonalds list. I am working on a school project, do you happen to have the file in anotehr format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants