Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple unit tests #8

Closed
6 tasks done
gavv opened this issue Jul 10, 2020 · 3 comments
Closed
6 tasks done

Add simple unit tests #8

gavv opened this issue Jul 10, 2020 · 3 comments
Assignees
Labels
good first issue Good for newcomers help wanted Contributions are welcome tests Improvements or additions to tests

Comments

@gavv
Copy link
Owner

gavv commented Jul 10, 2020

Currently we have no unit tests at all.

For some of the components developing a correct test wouldn't be trivial. However we can at least start with adding tests for a few components that can be covered easily:

  • MovMax
  • MovAvg
  • MovDev
  • MovGradient
  • MovPercentile
  • SchmittTrigger

I suggest to implement tests using Google Test library. We'll have to add it to 3rdparty directory as a submodule and add to CMake like we do it here: https://github.com/roc-streaming/rt-tests/blob/master/CMakeLists.txt#L5-L25

We should also add test step to CI.

@gavv gavv added help wanted Contributions are welcome good first issue Good for newcomers tests Improvements or additions to tests labels Jul 10, 2020
@gavv gavv removed the hacktoberfest label Dec 3, 2020
@saneck2150
Copy link
Contributor

Can i try to do this task?

@gavv
Copy link
Owner Author

gavv commented Oct 9, 2023

You're welcome :)

@gavv
Copy link
Owner Author

gavv commented Oct 7, 2024

Landed.

@gavv gavv closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Contributions are welcome tests Improvements or additions to tests
Projects
None yet
Development

No branches or pull requests

2 participants