Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump in Edifice: common4 #361

Closed
chapulina opened this issue Dec 14, 2020 · 3 comments
Closed

Bump in Edifice: common4 #361

chapulina opened this issue Dec 14, 2020 · 3 comments
Assignees

Comments

@chapulina
Copy link
Contributor

Bump edifice to use ign-common4 and ign-fuel-tools6.

The script in #333 should be helpful.

#331 may also be a helpful reference.

@chapulina chapulina changed the title Bump in Edifice: common4 and fuel-tools6 Bump in Edifice: common4 Jan 20, 2021
@chapulina chapulina assigned chapulina and unassigned mjcarroll Jan 22, 2021
This was referenced Jan 22, 2021
@scpeters
Copy link
Contributor

for osrf/homebrew-simulation, I think we need an ignition-common4 formula first, and it would be easier if we combined all those pull requests that update dependencies into a single PR, since new bottles need to be built at the same time

@chapulina
Copy link
Contributor Author

we need an ignition-common4 formula first

Ahh it was there, I just forgot to open the PR: osrf/homebrew-simulation#1308

it would be easier if we combined all those pull requests that update dependencies into a single PR

I originally kept them separate because I remember having trouble with a single PR. But if that's preferred I can combine them like I've been doing for release-tools and gazebodistro.

The tricky part is having all CI green before merging each source code PR, which requires nightlies for dependencies...

@scpeters
Copy link
Contributor

The tricky part is having all CI green before merging each source code PR, which requires nightlies for dependencies...

the alternative is to disable bottles by deleting the bottle block in affected formulae; then you can update formaule incrementally, but this has an effect of making our CI slow as well. we can also do a combination; disable bottles for edifice, launch, and gazebo, then update their dependencies all at once. it just depends on which package is the most problematic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants