Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actions/checkout@v2 is deprecated, replace with v3 #862

Closed
16 tasks done
scpeters opened this issue Dec 6, 2022 · 3 comments
Closed
16 tasks done

actions/checkout@v2 is deprecated, replace with v3 #862

scpeters opened this issue Dec 6, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@scpeters
Copy link
Contributor

scpeters commented Dec 6, 2022 •
edited
Loading

I noticed some deprecation warnings in our GitHub actions workflow results:

Screen Shot 2022-12-05 at 12 08 47 PM

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
Please update the following actions to use Node.js 16: actions/checkout@v2

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

https://github.com/gazebosim/sdformat/blob/fdc4984a2f0e70a9116c81523cdfdcf8ed15e130/.github/workflows/ci.yml#L11

Status
scpeters added a commit to gazebosim/gz-cmake that referenced this issue Dec 6, 2022
@scpeters
CI workflow: use checkout v3
c6a206f 
Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Dec 6, 2022
Merged
8 tasks
mjcarroll pushed a commit to gazebosim/gz-cmake that referenced this issue Dec 6, 2022
@scpeters
CI workflow: use checkout v3 (#327)
99a5641 
Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Contributor Author

scpeters commented Dec 7, 2022

I've updated actions/checkout@v2 to actions/checkout@v3 for ign-cmake2 in gazebosim/gz-cmake#327 and merged forward to gz-cmake3 and main. Before proceeding with the rest of our repositories, are we happy with this solution? I suppose we could try to maintain our own fork of actions/checkout and point to a branch on that repository, but that feels like a lot of work as well to keep that repository synchronized with upstream.

I think just manually changing v2 to v3 seems like the right thing, but I wanted to at least see if anyone else has a better idea first.

@scpeters
Copy link
Contributor Author

scpeters commented Dec 8, 2022

I believe v2 and v3 are actually tags that get rewritten to point to the most recent minor tag?

I would have thought a branch would be preferred for that

scpeters added a commit to gazebosim/gz-utils that referenced this issue Dec 8, 2022
@scpeters
CI workflow: use checkout v3
073a6e8 
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Dec 8, 2022
Merged
8 tasks
nkoenig pushed a commit to gazebosim/gz-utils that referenced this issue Dec 8, 2022
@scpeters
CI workflow: use checkout v3 (#85)
40a492c 
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/gz-math that referenced this issue Dec 20, 2022
@scpeters
CI workflow: use checkout v3
22f4bd5 
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Dec 20, 2022
Merged
8 tasks
scpeters added a commit to gazebosim/gz-math that referenced this issue Dec 28, 2022
@scpeters
CI workflow: use checkout v3 (#519)
3737ac1 
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/sdformat that referenced this issue Jan 31, 2023
@scpeters
CI workflow: use checkout v3
30c7e66 
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Jan 31, 2023
Merged
8 tasks
@scpeters scpeters added the good first issue Good for newcomers label Jan 31, 2023
scpeters added a commit to gazebosim/sdformat that referenced this issue Feb 1, 2023
@scpeters
CI workflow: use checkout v3 (#1225)
fb69269 
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/sdformat that referenced this issue Mar 3, 2023
@scpeters
CI workflow: use checkout v3
e2bbc6c 
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/gz-common that referenced this issue Mar 3, 2023
@scpeters
CI workflow: use checkout v3
7b7accd 
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This was referenced Mar 3, 2023
Merged
Merged
mjcarroll pushed a commit to gazebosim/gz-common that referenced this issue Mar 3, 2023
@scpeters
CI workflow: use checkout v3 (#490)
131d2e7 
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
mjcarroll pushed a commit to gazebosim/sdformat that referenced this issue Mar 3, 2023
@scpeters
CI workflow: use checkout v3 (#1245)
3a13dc5 
Version v2 of the actions/checkout workflow is deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/gz-rendering that referenced this issue Mar 14, 2023
@scpeters
CI workflow: use checkout v3
d69c737 
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Mar 14, 2023
Merged
8 tasks
iche033 pushed a commit to gazebosim/gz-rendering that referenced this issue Mar 14, 2023
@scpeters
CI workflow: use checkout v3 (#834)
4707827 
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/gz-physics that referenced this issue Mar 14, 2023
@scpeters
CI workflow: use checkout v3
40f257d 
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Mar 14, 2023
Merged
8 tasks
mjcarroll pushed a commit to gazebosim/gz-physics that referenced this issue Mar 14, 2023
@scpeters
CI workflow: use checkout v3 (#488)
1e6168c 
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/gz-msgs that referenced this issue Mar 14, 2023
@scpeters
CI workflow: use checkout v3
be5357c 
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Mar 14, 2023
Merged
8 tasks
scpeters added a commit to gazebosim/gz-plugin that referenced this issue Mar 15, 2023
@scpeters
CI workflow: use checkout v3
38ce13e 
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/gz-transport that referenced this issue Mar 16, 2023
@scpeters
CI workflow: use checkout v3
8818ff5 
Version v2 of the actions/checkout workflow is deprecated,
so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Mar 16, 2023
Merged
8 tasks
azeey pushed a commit to gazebosim/gz-physics that referenced this issue Mar 16, 2023
@scpeters
CI workflow: use checkout v3 (#490)
b184e6f 
Version v2 of the actions/checkout workflow is deprecated,
so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
azeey pushed a commit to gazebosim/gz-fuel-tools that referenced this issue Mar 20, 2023
@scpeters
CI workflow: use checkout v3 (#334)
e53cc7c 
Version v2 of the actions/checkout workflow is deprecated,
so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
azeey pushed a commit to gazebosim/gz-transport that referenced this issue Mar 20, 2023
@scpeters
CI workflow: use checkout v3 (#391)
fc5d454 
Version v2 of the actions/checkout workflow is deprecated,
so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/gz-transport that referenced this issue Mar 21, 2023
@scpeters
CI workflow: use checkout v3
fd6f1f5 
Version v2 of the actions/checkout workflow is deprecated,
so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Mar 21, 2023
Merged
8 tasks
scpeters added a commit to gazebosim/gz-sensors that referenced this issue Mar 21, 2023
@scpeters
CI workflow: use checkout v3
16f39f2 
Version v2 of the actions/checkout workflow is deprecated,
so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Mar 21, 2023
Merged
8 tasks
scpeters added a commit to gazebosim/gz-gui that referenced this issue Mar 22, 2023
@scpeters
CI workflow: use checkout v3
ac1f2a2 
Version v2 of the actions/checkout workflow is deprecated,
so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Mar 22, 2023
Merged
8 tasks
scpeters added a commit to gazebosim/gz-sim that referenced this issue Mar 22, 2023
@scpeters
CI workflow: use checkout v3
08d5dca 
Version v2 of the actions/checkout workflow is deprecated,
so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Mar 22, 2023
Merged
8 tasks
scpeters added a commit to gazebosim/gz-launch that referenced this issue Mar 22, 2023
@scpeters
CI workflow: use checkout v3 (#490)
8924667 
Version v2 of the actions/checkout workflow is deprecated,
so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Mar 22, 2023
Merged
8 tasks
scpeters added a commit to gazebosim/gz-gui that referenced this issue Mar 23, 2023
@scpeters
CI workflow: use checkout v3 (#526)
c7498f1 
Version v2 of the actions/checkout workflow is deprecated,
so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
mjcarroll pushed a commit to gazebosim/gz-sim that referenced this issue Mar 23, 2023
@scpeters
CI workflow: use checkout v3 (#1940)
6437bb0 
Version v2 of the actions/checkout workflow is deprecated,
so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
mjcarroll pushed a commit to gazebosim/gz-launch that referenced this issue Mar 23, 2023
@scpeters
CI workflow: use checkout v3 (#490) (#213)
7eeff11 
Version v2 of the actions/checkout workflow is deprecated,
so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
iche033 pushed a commit to gazebosim/gz-sensors that referenced this issue Mar 24, 2023
@scpeters
CI workflow: use checkout v3 (#335)
cb18240 
Version v2 of the actions/checkout workflow is deprecated,
so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/gz-transport that referenced this issue Mar 24, 2023
@scpeters
CI workflow: use checkout v3 (#394)
8b7835c 
Version v2 of the actions/checkout workflow is deprecated,
so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit to gazebosim/gz-gui that referenced this issue Apr 17, 2023
@scpeters
CI workflow: use checkout v3
790378f 
Version v2 of the actions/checkout workflow is deprecated,
so switch to v3.

Follow-up to #526 that missed jammy when merged forward.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Apr 17, 2023
Merged
8 tasks
scpeters added a commit to gazebosim/gz-gui that referenced this issue Apr 18, 2023
@scpeters
CI workflow: use checkout v3 (#536)
af8185f 
Version v2 of the actions/checkout workflow is deprecated,
so switch to v3.

Follow-up to #526 that missed jammy when merged forward.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Contributor Author

just waiting on one last forward port to gazebosim/gz-gui#538 and then I'll close this issue

@scpeters scpeters closed this as completed May 2, 2023
danilogsch pushed a commit to danilogsch/gz-math that referenced this issue Jun 1, 2023
@scpeters @danilogsch
CI workflow: use checkout v3 (gazebosim#519)
aa97e31 
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@azeey azeey moved this to In progress in Core development Jul 24, 2023
mjcarroll added a commit to gazebosim/gz-math that referenced this issue Aug 22, 2023
@danilogsch @ahcorde
@scpeters @nkoenig @mjcarroll @azeey @muttistefano
MecanumDriveOdometry to handle odometry estimation of Mecanum wheeled…
469540c 
… models (#486)

* Class ignition::math::MecanumDriveOdometryPrivate to handle Mecanum wheels odometry

Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* Update include/ignition/math/MecanumDriveOdometry.hh

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* Update include/ignition/math/MecanumDriveOdometry.hh

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* Update include/ignition/math/MecanumDriveOdometry.hh

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* Update src/MecanumDriveOdometry.cc

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* MecanumDrive doc

Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* MecanumDrive doc

Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>

* Update MecanumDriveOdometry.cc

line length corrections

* Update include/ignition/math/MecanumDriveOdometry.hh

* CI workflow: use checkout v3 (#519)

Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* Rename COPYING to LICENSE (#521)

The LICENSE file contained a copy of the stanze
used at the top of source code files, while the
actual license was in the COPYING file. So remove
the stanza and put the actual Apache 2.0 license text
in LICENSE.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

* Custom PID error rate (#525)

* Custom PID error rate

Signed-off-by: Nate Koenig <natekoenig@gmail.com>

* added test

Signed-off-by: Nate Koenig <natekoenig@gmail.com>

---------

Signed-off-by: Nate Koenig <natekoenig@gmail.com>

* Add option to skip pybind11 and SWIG (#480)

Signed-off-by: Michael Carroll <michael@openrobotics.org>

* Disable pybind11 on windows by default (#529)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

* 🎈 6.14.0 (#531)

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

* Lint

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>

* Port changes and tests from muttistefano

Co-authored-by: muttistefano <mutti.stefano.jp@gmail.com>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>

* Add accessor and TODO note

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>

---------

Signed-off-by: danilo_gsch <danilo_gsch@hotmail.com>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Nate Koenig <natekoenig@gmail.com>
Co-authored-by: Michael Carroll <michael@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Co-authored-by: Michael Carroll <mjcarroll@intrinsic.ai>
Co-authored-by: muttistefano <mutti.stefano.jp@gmail.com>
@mjcarroll mjcarroll moved this from In progress to Done in Core development Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scpeters